-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated volcano logo #422
Updated volcano logo #422
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Klaus Ma <mada3@huawei.com>
Hey @k82cn, TravisCI finished with status TravisBuddy Request Identifier: 26567f50-c300-11e9-86a4-77838e0d0b7a |
Why you remove these jobs? |
it's unstable, sometime the whole tasks got cancelled :( |
@k82cn The process you deleted are not triggered for the common PR builds. And the unstable issue is related to the E2E tests not the publish stage, we may need investigating on how to avoid this. |
@TommyLike , I had meet several times that the CI was cancelled but all e2e tests were passed. Let's revert it when it's ready for us. |
@k82cn Usually we have several jobs for one PR build, if one specific job failed, for example the E2E job, then the following jobs (publish) would be canceled. In this case we can trigger two different events in travis.ci website.
If we only restart the job , the E2E test may pass next time, but the build still marked canceled, But if we restart the build, that would be ok I think. I trigged a whole rebuild for this #421, let's see the result. |
Is there anyway to fix that? I don-t want to put effort on identify which button I should push :(. If we can not fix that, just use a script to include all related tests. |
I removed the modification to .trivis, it's seems it does not work too.
That's really a bad contributor experience, please open an issue to fix that. |
If not more questions/comments, let's get logo update merged :) |
/lgtm |
Signed-off-by: Klaus Ma mada3@huawei.com