Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated volcano logo #422

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Updated volcano logo #422

merged 1 commit into from
Aug 22, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Aug 20, 2019

Signed-off-by: Klaus Ma mada3@huawei.com

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2019
Signed-off-by: Klaus Ma <mada3@huawei.com>
@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 26567f50-c300-11e9-86a4-77838e0d0b7a

@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2019
@hzxuzhonghu
Copy link
Collaborator

Why you remove these jobs?

@k82cn
Copy link
Member Author

k82cn commented Aug 20, 2019

it's unstable, sometime the whole tasks got cancelled :(

@TommyLike
Copy link
Contributor

TommyLike commented Aug 20, 2019

@k82cn The process you deleted are not triggered for the common PR builds. And the unstable issue is related to the E2E tests not the publish stage, we may need investigating on how to avoid this.

@k82cn
Copy link
Member Author

k82cn commented Aug 20, 2019

@TommyLike , I had meet several times that the CI was cancelled but all e2e tests were passed. Let's revert it when it's ready for us.

@TommyLike
Copy link
Contributor

@k82cn Usually we have several jobs for one PR build, if one specific job failed, for example the E2E job, then the following jobs (publish) would be canceled. In this case we can trigger two different events in travis.ci website.

  1. Restart the job
  2. Restart the whole build.

If we only restart the job , the E2E test may pass next time, but the build still marked canceled, But if we restart the build, that would be ok I think.

I trigged a whole rebuild for this #421, let's see the result.

@k82cn
Copy link
Member Author

k82cn commented Aug 20, 2019

If we only restart the job , the E2E test may pass next time, but the build still marked canceled, But if we restart the build, that would be ok I think.

Is there anyway to fix that? I don-t want to put effort on identify which button I should push :(. If we can not fix that, just use a script to include all related tests.

@TommyLike
Copy link
Contributor

If we only restart the job , the E2E test may pass next time, but the build still marked canceled, But if we restart the build, that would be ok I think.

Is there anyway to fix that? I don-t want to put effort on identify which button I should push :(. If we can not fix that, just use a script to include all related tests.

If we want to retrigger the build on the website, I guess we need to get used to the Travis's design.
image
But if we want a more convenient way, I think we need add this support in ci bot.

@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2019
@k82cn
Copy link
Member Author

k82cn commented Aug 21, 2019

I removed the modification to .trivis, it's seems it does not work too.

But if we want a more convenient way, I think we need add this support in ci bot.

That's really a bad contributor experience, please open an issue to fix that.

@k82cn
Copy link
Member Author

k82cn commented Aug 22, 2019

If not more questions/comments, let's get logo update merged :)

@hzxuzhonghu hzxuzhonghu changed the title Updated volcano log. Updated volcano logo Aug 22, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2019
@volcano-sh-bot volcano-sh-bot merged commit f667715 into volcano-sh:master Aug 22, 2019
@k82cn k82cn deleted the update_logo branch December 25, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants