-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set the json name of exitCode #439
Conversation
Welcome @davidstack! |
pkg/apis/batch/v1alpha1/job.go
Outdated
@@ -193,7 +193,7 @@ type LifecyclePolicy struct { | |||
// according to this code. | |||
// Note: only one of `Event` or `ExitCode` can be specified. | |||
// +optional | |||
ExitCode *int32 | |||
ExitCode *int32 `json:"exitCode,omitempty" protobuf:"bytes,3,opt,name=exitCode"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
It should be 5
, 3
is used by Events
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it,i have changed this.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidstack, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
set the json name of exitCode ,so we can specify the exitcode in the policies. policies: - exitCode: 137 action: RestartJob
/lgtm |
set the json name of exitCode ,so we can specify the exitcode in the policies.
policies:
- exitCode: 137
action: RestartJob