Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify the return value of 'vcctl' #460

Merged
merged 1 commit into from
Sep 21, 2019
Merged

modify the return value of 'vcctl' #460

merged 1 commit into from
Sep 21, 2019

Conversation

jiangkaihua
Copy link
Contributor

@jiangkaihua jiangkaihua commented Sep 19, 2019 •
edited
Loading

Fixes #454

in cmd/cli/vkctl.go, return error code '2' instead of '0' when error occurs in 'vcctl', so that cromwell can read the correct 'check-alive' which refers to 'vcctl job view -N '.

in pkg/cli/job.go, when job is nil, do not run the default job 'test', print the error output and return nil.

@volcano-sh-bot
Copy link
Contributor

Welcome @jiangkaihua!

It looks like this is your first PR to volcano-sh/volcano 🎉.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 19, 2019
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2019
k82cn
k82cn reviewed Sep 19, 2019
View reviewed changes
pkg/cli/job/run.go
@@ -72,23 +73,14 @@ func RunJob() error {
return err
}

req, err := populateResourceListV1(launchJobFlags.Requests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function runs twice to get arg 'req' and 'limit', and the two args are used only when the default job 'test' is started.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got that.

@k82cn
Copy link
Member

k82cn commented Sep 19, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiangkaihua, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@k82cn
Copy link
Member

k82cn commented Sep 19, 2019

please fix ci error and merge commits.

@jiangkaihua jiangkaihua requested a review from k82cn September 19, 2019 08:52
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 63d29840-dac1-11e9-a83c-6d8e6b7d4c6a

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @jiangkaihua,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b8e654b0-dad6-11e9-a83c-6d8e6b7d4c6a

@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2019
@jiangkaihua
Add vcctl error.
ab04a3d 
Signed-off-by: jiangkaihua <54176503+jiangkaihua@users.noreply.github.com>
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 21, 2019
@k82cn
Copy link
Member

k82cn commented Sep 21, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2019
@volcano-sh-bot volcano-sh-bot merged commit 59dc80d into volcano-sh:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'vcctl job run' executes with no arguments
4 participants
@jiangkaihua @volcano-sh-bot @k82cn @TravisBuddy