Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission: Fall back to v1alpha1 podgroup when v1alpha2 doesnot exist #488

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

This is to fix dependents that are still using the v1alpha1 podgroup.

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2019
@k82cn
Copy link
Member

k82cn commented Oct 24, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9025d130-f643-11e9-9890-1bf57bc9f734

@hzxuzhonghu hzxuzhonghu merged commit 888f0d0 into volcano-sh:master Oct 24, 2019
@hzxuzhonghu hzxuzhonghu deleted the admission branch October 24, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants