Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add priorityClassName to podgroup during creating of podgroup from pod #497

Merged
merged 3 commits into from
Oct 30, 2019
Merged

add priorityClassName to podgroup during creating of podgroup from pod #497

merged 3 commits into from
Oct 30, 2019

Conversation

sivanzcw
Copy link
Contributor

issues #494

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 72969570-fa5b-11e9-97f1-ff8640b58534

@k82cn
Copy link
Member

k82cn commented Oct 30, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, sivanzcw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 397127e0-fac1-11e9-94bd-fbbf6873bcfd

@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 4b91a8a0-fac1-11e9-94bd-fbbf6873bcfd

@hzxuzhonghu
Copy link
Collaborator

wait, donot update by hand. Let me have a look

@hzxuzhonghu hzxuzhonghu added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@volcano-sh-bot volcano-sh-bot merged commit 7ea913e into volcano-sh:master Oct 30, 2019
@sivanzcw sivanzcw mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@TommyLike TommyLike Awaiting requested review from TommyLike

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivanzcw @TravisBuddy @k82cn @volcano-sh-bot @hzxuzhonghu