fix filter NotReady node #507
Conversation
volcano-sh-bot
added
the
size/S
pkg/scheduler/api/node_info.go
Outdated
| @@ -126,6 +128,16 @@ func (ni *NodeInfo) setNodeState(node *v1.Node) { | |||
| return | |||
| } | |||
|
|
|||
| var nodeInfo cache.NodeInfo | |||
| nodeInfo.SetNode(ni.Node) | |||
| if fit, _, _ := predicates.CheckNodeConditionPredicate(nil, nil, &nodeInfo); !fit { | |||
There was a problem hiding this comment.
How to work together with TaintNodeByCondition?
There was a problem hiding this comment.
xref: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/scheduling/taint-node-by-condition.md
the example at the end of this document may be help.
There was a problem hiding this comment.
now in AddPredicateFn we use func CheckNodeConditionPredicate, if conditions have some type and status, like NodeNetworkUnavailable, true, the pod can't be scheduled.
i move the same func CheckNodeConditionPredicate for node forward. so AddPredicateFn also is incorrect?
There was a problem hiding this comment.
@k82cn please help to review :)
|
Hey @wangyuqing4, TravisBuddy Request Identifier: c03fac70-fea8-11e9-b5b5-d568244b8b3c |
|
Hey @wangyuqing4, TravisBuddy Request Identifier: 9a79d880-0141-11ea-82f1-cf3ba55cf6d0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, wangyuqing4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
when openSession get ssn.Node, don't filter notReady node, so calculate totalResource incorrect.