-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state parameter to queueSpec and queueStatus for queue #508
Conversation
Hey @sivanzcw, TravisBuddy Request Identifier: e29bf680-fef7-11e9-b5b5-d568244b8b3c |
pkg/apis/scheduling/types.go
Outdated
} | ||
|
||
// QueueSpec represents the template of Queue. | ||
type QueueSpec struct { | ||
Weight int32 | ||
Capability v1.ResourceList | ||
// State controller the status of queue | ||
State string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/string/QueueState/g
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, sivanzcw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @sivanzcw, TravisCI finished with status TravisBuddy Request Identifier: 6bc072b0-ffa2-11e9-b0ee-092ac02b7026 |
Hey @sivanzcw, TravisBuddy Request Identifier: 32c27e30-ffa3-11e9-b0ee-092ac02b7026 |
Hey @sivanzcw, TravisCI finished with status TravisBuddy Request Identifier: e37ca660-ffa3-11e9-b0ee-092ac02b7026 |
Hey @sivanzcw, TravisBuddy Request Identifier: 8cfa50e0-ffb1-11e9-b0ee-092ac02b7026 |
In order to subsequently manage queue through the
state
of queue, addstate
parameter to queue structAdd valid queue states
Add update queue logic to queue controller, when queue state changes the
state
of queue can be refreshed