ssh plugin support specifying private/public keys path

[hzxuzhonghu]

Added ssh-key-file-path to allow users to specify the path of ssh keys. For example if you want to store the keys in /a/b, the blowing config can work.

apiVersion: batch.volcano.sh/v1alpha1
kind: Job
metadata:
  name: lm-horovod-job
  labels:
    "volcano.sh/job-type": Horovod
spec:
  minAvailable: 4
  schedulerName: volcano
  plugins:
    ssh: ["--ssh-key-file-path=/a/b"]    # or ["--ssh-key-file-path", "/a/b"]

[hzxuzhonghu]

Fixes: #403

[k82cn]

please list the value table for --no-root and ssh-key-file-path.

[TravisBuddy]

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 5f3d74a0-0161-11ea-82f1-cf3ba55cf6d0

[hzxuzhonghu]

please list the value table for --no-root and ssh-key-file-path.

Sorry, i can not catch this.

[TravisBuddy]

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ef9f1520-01da-11ea-8e58-e963e1672326

[TravisBuddy]

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: fb19bca0-0218-11ea-8e58-e963e1672326

[TravisBuddy]

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 958e5370-0432-11ea-8ac3-8db289d111a9

[hzxuzhonghu]

ping @k82cn

[dalfos]

@hzxuzhonghu have you example of job how to use ssh & mpi in userspace?

[k82cn]

@hzxuzhonghu , please help to list expected result when --no-root & --ssh-key have different value.

[k82cn]

@hzxuzhonghu have you example of job how to use ssh & mpi in userspace?

@dalfos , a initContainer or script is necessary to copy private/public key into ~/.ssh to run mpi job in userspace.

[dalfos]

@k82cn maybe add param --port $port which adds lines "Port $port" for master and workers in .ssh/config. User cannot start sshd on port 22 (I started for example on port 2222).

[dalfos]

@k82cn maybe add param --port $port which adds lines "Port $port" for master and workers in .ssh/config. User cannot start sshd on port 22 (I started for example on port 2222).

I found in mpirun:
-mca plm_rsh_args "-p 2222"

[hzxuzhonghu]

Yes, we donot care about the port of sshd in volcano.

@hzxuzhonghu have you example of job how to use ssh & mpi in userspace?

What do u mean by userspace?

@hzxuzhonghu , please help to list expected result when --no-root & --ssh-key have different value.

if --ssh-key-file-path is specified, no-root is not cared about, i want to remove the no-root flag in future.

[dalfos]

@hzxuzhonghu I mean case then sshd is executed by user (not by root).
All my questions are settled. Thank you!

[k82cn]

if --ssh-key-file-path is specified, no-root is not cared about, i want to remove the no-root flag in future.

ok, so the default value of --ssh-key-file-path will be /root/.ssh ?

[hzxuzhonghu]

Yes

[k82cn]

/lgtm
/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [k82cn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment