Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify scheduling events for pod and podgroup #520

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Modify scheduling events for pod and podgroup #520

merged 1 commit into from
Nov 12, 2019

Conversation

sivanzcw
Copy link
Contributor

@sivanzcw sivanzcw commented Nov 8, 2019

#519

  • Change job is not ready to pod group is not ready

  • If status of podgroup is inqueue, record unschedulable events for podgroup

  • record scheduled events for podgroup during bind pod to node

events of pod will be like

Events:
  Type     Reason            Age   From     Message
  ----     ------            ----  ----     -------
  Warning  FailedScheduling  45m   volcano  10/6 tasks in gang unschedulable: pod group is not ready, 10 minAvailable, 6 Pending.
  Warning  FailedScheduling  45m   volcano  10/10 tasks in gang unschedulable: pod group is not ready, 10 Pending, 10 minAvailable.
  Warning  FailedScheduling  45m   volcano  10/16 tasks in gang unschedulable: pod group is not ready, 10 minAvailable, 16 Pending.
  Warning  FailedScheduling  44m   volcano  10/22 tasks in gang unschedulable: pod group is not ready, 10 minAvailable, 22 Pending.
  Warning  FailedScheduling  44m   volcano  10/26 tasks in gang unschedulable: pod group is not ready, 10 minAvailable, 26 Pending.
  Warning  FailedScheduling  44m   volcano  10/30 tasks in gang unschedulable: pod group is not ready, 10 minAvailable, 30 Pending.

events for podgroup will be like:

Status:
  Phase:    Running
  Running:  12
Events:
  Type     Reason         Age                From     Message
  ----     ------         ----               ----     -------
  Warning  Unschedulable  53s (x3 over 55s)  volcano  0/0 tasks in gang unschedulable: pod group is not ready, 12 minAvailable.
  Warning  Unschedulable  46s (x7 over 52s)  volcano  6/6 tasks in gang unschedulable: pod group is not ready, 12 minAvailable, 6 Pending.
  Warning  Unschedulable  38s (x8 over 45s)  volcano  10/10 tasks in gang unschedulable: pod group is not ready, 10 Pending, 12 minAvailable.
  Normal   Scheduled      37s (x7 over 37s)  volcano  2/14 tasks in gang unschedulable: pod group is ready, 12 minAvailable, 2 Pending

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2019
@sivanzcw sivanzcw force-pushed the bugfix branch 2 times, most recently from c205534 to e19c365 Compare November 9, 2019 08:29
@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f77127f0-02d1-11ea-bbb5-2bfb3cbbfe32

hzxuzhonghu
hzxuzhonghu reviewed Nov 11, 2019
View reviewed changes
pkg/apis/scheduling/types.go
type PodGroupSchedulingStatus string

const (
// PodGroupReady is that PodGroup has reached scheduling restriction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduling condition or scheduling requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to PodGroupConditionDetail according to type of events PodGroupConditionType

hzxuzhonghu
hzxuzhonghu reviewed Nov 11, 2019
View reviewed changes
pkg/apis/scheduling/types.go
PodGroupUnschedulableType PodGroupConditionType = "Unschedulable"

// PodGroupScheduled is scheduled event type
PodGroupScheduled PodGroupConditionType = "Scheduled"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to both v1alpha1 and v1alpha2 types.go？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

hzxuzhonghu
hzxuzhonghu reviewed Nov 11, 2019
View reviewed changes
pkg/apis/scheduling/types.go Outdated
// PodGroupReady is that PodGroup has reached scheduling restriction
PodGroupReady PodGroupSchedulingStatus = "pod group is ready"
// PodGroupNotReady is that PodGroup has not yet reached the scheduling restriction
PodGroupNotReady PodGroupSchedulingStatus = "pod group is not ready"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ad4d2c40-0467-11ea-8ac3-8db289d111a9

@k82cn
Copy link
Member

k82cn commented Nov 11, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, sivanzcw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a45b6ac0-04f3-11ea-9b49-e31b2b39913b

@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@volcano-sh-bot volcano-sh-bot merged commit 4433c09 into volcano-sh:master Nov 12, 2019
@sivanzcw sivanzcw mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@hex108 hex108 Awaiting requested review from hex108

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivanzcw @TravisBuddy @k82cn @volcano-sh-bot @hzxuzhonghu