Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdb bug 修复 #523

Merged
merged 2 commits into from
Nov 13, 2019
Merged

pdb bug 修复 #523

merged 2 commits into from
Nov 13, 2019

Conversation

chenshaojin
Copy link

修复scheduler job_info.SetPDB(…) ，引发的：Panic： invalid memory address or nil pointer dereference

@volcano-sh-bot
Copy link
Contributor

Welcome @chenshaojin!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @chenshaojin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 17861970-05e7-11ea-a6d4-35dac06c1dc7

@k82cn
Copy link
Member

k82cn commented Nov 13, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenshaojin, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@k82cn
Copy link
Member

k82cn commented Nov 13, 2019

LGTM overall; @chenshaojin , would you help to make CI happy? It seems a gofmt is enough.

@chenshaojin
Copy link
Author

Yes, the detection robot detected the formatting code problem. I have fixed it. @k82cn

@k82cn
Copy link
Member

k82cn commented Nov 13, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@TravisBuddy
Copy link

Hey @chenshaojin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 075a5510-05ed-11ea-a6d4-35dac06c1dc7

@TravisBuddy
Copy link

Hey @chenshaojin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a3d122e0-05f5-11ea-a6d4-35dac06c1dc7

@volcano-sh-bot volcano-sh-bot merged commit 8a78ddf into volcano-sh:master Nov 13, 2019
@k82cn k82cn mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenshaojin @volcano-sh-bot @TravisBuddy @k82cn