Simplify job pvc create process #544
Conversation
volcano-sh-bot
added
the
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
Hey @hzxuzhonghu, TravisCI finished with status TravisBuddy Request Identifier: 8f528d60-0c15-11ea-9cd6-8f216fa7db85 |
|
New changes are detected. LGTM label has been removed. |
volcano-sh-bot
added
size/L
| @@ -26,47 +26,6 @@ import ( | |||
| ) | |||
|
|
|||
| var _ = Describe("Job E2E Test: Test Job PVCs", func() { | |||
| It("Generate PVC name if not specified", func() { | |||
There was a problem hiding this comment.
I changed the behavior: previously if only MountPath defined under JobSpec.Volumes, job controller will create an emptydir pvc for it. This is unreasonable behavior, emptydir is not suggested to be used in production. Also volcano users will not use it, if they really need , they should declare it explicitly. We don't want to set too many default values for it.
There was a problem hiding this comment.
And i will update the api doc in a following pr.
There was a problem hiding this comment.
emptydir is not suggested to be used in production
by k8s community?
|
Hey @hzxuzhonghu, TravisBuddy Request Identifier: 48c6d920-0c36-11ea-9489-798921b627f8 |
This is to simplify
createJobIOIfNotExistand fix some unreasonable logic, likejob.Status.ControlledResources["volume-emptyDir-"+vcName] = vcName.