some minor cleanup and optmization #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM overall, let's get it merged when CI is happy :) |
|
Sorry, forget to set gofmt |
k82cn
reviewed
Apr 2, 2019
pkg/controllers/job/cache/cache.go
Outdated
| func (jc *jobCache) processCleanupJob() { | ||
| func (jc *jobCache) worker() { | ||
| for jc.processCleanupJob() { | ||
|
|
k82cn
reviewed
Apr 2, 2019
| "github.com/golang/glog" | ||
| "sync" |
|
merge the three commits into one. |
|
done |
wangyuqing4
pushed a commit
to wangyuqing4/volcano-1
that referenced
this pull request
Apr 30, 2019
【Issue volcano-sh#57】【BUG2019040101375 】【BUG2019032102153 】增加policy中action和events的校验，去掉RestartTask action 单号: BUG2019040101375; BUG2019032102153 特性/模块名称: volcano-admission 修改原因: 1. policy中RestartTask action配置后不生效 2. policy中action和event缺少校验 修改内容： 1. RestartTask未被state实现，去掉这个action 2. 增加policy中可配置action和event的校验,action的可取值为"AbortJob","RestartJob","TerminateJob","CompleteJob","ResumeJob" events的可取值为"*","PodFailed","PodEvicted","Unknown",“TaskCompleted” 自验情况 自验通过 验证yaml [policy.yaml](/uploads/2d684ceab9b5a399571c4aff233e790b/policy.yaml) 验证结果   Issues info: Issue ID: 57 Title: 【BUG2019040101375 】restartTask不生效【BUG2019032102153 】envents/action组合不合理 Issue url: CBU-PaaS/Community/volcano/volcano#57 See merge request CBU-PaaS/Community/volcano/volcano!92
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove some unnecessary fields in controller
reduce the depend on wait.until to call handler func for each item, which requires more cost.