-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update factory.go #614
Update factory.go #614
Conversation
replace parameter type
Welcome @YesterdayxD! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, YesterdayxD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -40,7 +40,7 @@ var pluginBuilders = map[string]PluginBuilder{} | |||
type PluginBuilder func(pluginsinterface.PluginClientset, []string) pluginsinterface.PluginInterface | |||
|
|||
// RegisterPluginBuilder register plugin builders | |||
func RegisterPluginBuilder(name string, pc func(pluginsinterface.PluginClientset, []string) pluginsinterface.PluginInterface) { | |||
func RegisterPluginBuilder(name string, PluginBuilder) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you need a param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
/lgtm |
Hey @YesterdayxD, TravisCI finished with status TravisBuddy Request Identifier: 94c3f2f0-1fdb-11ea-ba47-7f442aed9c1e |
Hey @YesterdayxD, TravisCI finished with status TravisBuddy Request Identifier: d226c400-1fe1-11ea-ba47-7f442aed9c1e |
Hey @YesterdayxD, TravisBuddy Request Identifier: e9a96d10-1fe8-11ea-ba47-7f442aed9c1e |
replace parameter type