remove repeated code.

[YesterdayxD]

Line 56-58 has same effect.

[YesterdayxD]

or

if pod.Spec.SchedulerName != job.Spec.SchedulerName {
		pod.Spec.SchedulerName = job.Spec.SchedulerName
	}

aim to make the name
@hzxuzhonghu

[TravisBuddy]

Hey @YesterdayxD,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ec4919d0-223b-11ea-b76a-c509dfe0ae07

[TravisBuddy]

Hey @YesterdayxD,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 40505b30-2244-11ea-b76a-c509dfe0ae07

[hzxuzhonghu]

@YesterdayxD Good catch， i prefer #627 (comment)

[hzxuzhonghu]

And one step further, i would like to deprecate the JobSpec.SchedulerName, because for volcano, it is meaningless to allow specifying a different scheduler name.

[k82cn]

i would like to deprecate the JobSpec.SchedulerName

Please do not do that, that'll make user set schedulerName for each pod-template. We can validate it by admission controller.

[YesterdayxD]

/assign @hzxuzhonghu

[k82cn]

/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, YesterdayxD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controllers/OWNERS [k82cn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[YesterdayxD]

Please add lgtm label.

[k82cn]

@hzxuzhonghu , is that ok for you?

[hzxuzhonghu]

yeah
/lgtm