Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create jobs until pg inqueue #634

Merged
merged 4 commits into from
Jan 5, 2020
Merged

Do not create jobs until pg inqueue #634

merged 4 commits into from
Jan 5, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

Fixes: #621

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7892a720-2580-11ea-8c31-f79bb2699b7f

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bb33d390-2587-11ea-8c31-f79bb2699b7f

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 297d5e80-262c-11ea-8748-5b98fb6aa2de

@hzxuzhonghu
Copy link
Collaborator Author

@k82cn Please let me know if this make sense to you, so i can decide if i should work on fixing ci. Otherwise, i can close it.

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: fa441a60-2639-11ea-8748-5b98fb6aa2de

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 82fd7fe0-26bc-11ea-b014-cf6d669622bf

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7e535060-26ca-11ea-b014-cf6d669622bf

@hzxuzhonghu
Copy link
Collaborator Author

I am pretty sure the e2e is flaky

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 863b5810-2704-11ea-9fe8-03452f69915b

k82cn
k82cn reviewed Jan 2, 2020
View reviewed changes
pkg/controllers/job/job_controller_actions.go Outdated
if job, err = cc.createJob(job); err != nil {
return err
// Skip job initiation if job is already accepted
if job.Status.State.Phase == "" || job.Status.State.Phase == batch.Pending || job.Status.State.Phase == batch.Restarting {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add isInitialized func for this check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

k82cn
k82cn reviewed Jan 2, 2020
View reviewed changes
pkg/controllers/job/job_controller_actions.go
}
}
var syncTask bool
if pg, _ := cc.pgLister.PodGroups(job.Namespace).Get(job.Name); pg != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check this in handler?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure i am understanding what you mean. My thought is to split the SyncJob function: the first phase is initialization and the second phase is sync.

@k82cn
Copy link
Member

k82cn commented Jan 2, 2020

LGTM overall :)

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 1cd97940-2d41-11ea-a185-6fb6d15019ed

@k82cn
Copy link
Member

k82cn commented Jan 5, 2020

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2020
@volcano-sh-bot volcano-sh-bot merged commit a35595d into volcano-sh:master Jan 5, 2020
@hzxuzhonghu hzxuzhonghu deleted the inqueue branch January 6, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pod creating is denied by admission with podgroup phase is Pending
4 participants
@hzxuzhonghu @TravisBuddy @k82cn @volcano-sh-bot