Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen install yaml without v1alpha queue and poggroup #653

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d34eeca0-2adf-11ea-b3af-3392aa6c8569

@k82cn
Copy link
Member

k82cn commented Dec 31, 2019

how are we going to handle backward compatibility?

@hzxuzhonghu
Copy link
Collaborator Author

There is no backward compatibility issue. Firstly, this yaml is for developers only; secondly, we do not delete the old crd from k8s cluster.

@k82cn
Copy link
Member

k82cn commented Dec 31, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2019
@volcano-sh-bot volcano-sh-bot merged commit 40985c7 into volcano-sh:master Dec 31, 2019
@hzxuzhonghu hzxuzhonghu deleted the install branch December 31, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants