Add vcommands: vcancel, vsuspend, vresume. #656
Conversation
Updated in Dec. 24, 2019
volcano-sh-bot
added
the
size/L
cmd/cli/vcancel/main.go
Outdated
| rootCmd := cobra.Command{ | ||
| Use: "vcancel", | ||
| Short: "cancel a job", | ||
| Long: `command 'vcancel' has the same function as command "vcctl job delete"`, |
There was a problem hiding this comment.
it's not necessary to mention vcctl as we're going to remove that.
cmd/cli/vresume/main.go
Outdated
| } | ||
| } | ||
|
|
||
| func checkError(cmd *cobra.Command, err error) { |
|
/approve |
volcano-sh-bot
added
the
approved
|
Hey @jiangkaihua, TravisBuddy Request Identifier: 767d9210-2d3c-11ea-a185-6fb6d15019ed |
Makefile
Outdated
| @@ -92,3 +92,7 @@ verify: | |||
| verify-generated-yaml: | |||
| ./hack/check-generated-yaml.sh | |||
|
|
|||
| vcommands: | |||
Travis tests have failedHey @jiangkaihua, TravisBuddy Request Identifier: 1a43cb70-2e0b-11ea-8eaa-0b08c4ee3d08 |
pkg/cli/job/util.go
Outdated
| @@ -149,3 +151,17 @@ func HumanDuration(d time.Duration) string { | |||
| } | |||
| return fmt.Sprintf("%dy", int(hours/24/365)) | |||
| } | |||
|
|
|||
| func CheckError(cmd *cobra.Command, err error) { | |||
There was a problem hiding this comment.
move this into util.go in cmd directory.
Travis tests have failedHey @jiangkaihua, TravisBuddy Request Identifier: fb0dbc70-2e0f-11ea-8eaa-0b08c4ee3d08 |
Signed-off-by: jiangkaihua <54176503+jiangkaihua@users.noreply.github.com>
|
Hey @jiangkaihua, TravisCI finished with status TravisBuddy Request Identifier: 07f5a5d0-2e1d-11ea-8eaa-0b08c4ee3d08 |
|
Hey @jiangkaihua, TravisBuddy Request Identifier: 494b1e60-3053-11ea-9f42-315217d475c1 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiangkaihua, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.