Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use openssl to sign certificate instead of using k8s #709

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Use openssl to sign certificate instead of using k8s #709

merged 1 commit into from
Feb 19, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu commented Feb 19, 2020 •
edited
Loading

fixes: #704 #649

Verified, it can work now

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2020
@hzxuzhonghu hzxuzhonghu force-pushed the admission-certificate branch from ea5f2ec to 3ed82a4 Compare February 19, 2020 04:31
@k82cn
Copy link
Member

k82cn commented Feb 19, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d7083d80-52d3-11ea-985d-f1d8cf6581ea

@volcano-sh-bot volcano-sh-bot merged commit 4c6fa36 into volcano-sh:master Feb 19, 2020
@hzxuzhonghu hzxuzhonghu deleted the admission-certificate branch February 19, 2020 06:18
@hzxuzhonghu hzxuzhonghu mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate CA ERROR
4 participants
@hzxuzhonghu @k82cn @volcano-sh-bot @TravisBuddy