Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gomod to manage dependencies. #745

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

tizhou86
Copy link
Member

Use gomod to manage dependencies.

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 24, 2020
@tizhou86
Copy link
Member Author

/assign @k82cn

@k82cn
Copy link
Member

k82cn commented Mar 24, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, tizhou86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@volcano-sh-bot volcano-sh-bot merged commit 92db603 into volcano-sh:master Mar 24, 2020
@k82cn
Copy link
Member

k82cn commented Mar 24, 2020

@tizhou86 , should we remove dep config files?

@tizhou86
Copy link
Member Author

we can keep it for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants