Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Set Queue field when pod has queue name annotation #754

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

xiaogaozi
Copy link
Contributor

Fix #753

Add scheduling.volcano.sh/queue-name annotation key to identify which queue belong to. The controller will check if this annotation exists and set the Queue field.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2020
@xiaogaozi
Copy link
Contributor Author

/assign @kevin-wangzefeng

Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@hzxuzhonghu
Copy link
Collaborator

/approve

@k82cn
Copy link
Member

k82cn commented Apr 4, 2020

/approve
/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn, xiaogaozi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2020
@volcano-sh-bot volcano-sh-bot merged commit cc11027 into volcano-sh:master Apr 4, 2020
@xiaogaozi xiaogaozi deleted the fix/pod-group-queue branch April 16, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Cannot set the "Queue" field of "PodGroup" that automatically created by controller
5 participants