Support PrintVersion for scheduler&controller binaries #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k82cn
reviewed
Apr 9, 2019
| @@ -43,6 +44,7 @@ func (s *ServerOption) AddFlags(fs *pflag.FlagSet) { | |||
| fs.BoolVar(&s.EnableLeaderElection, "leader-elect", s.EnableLeaderElection, "Start a leader election client and gain leadership before "+ | |||
| "executing the main loop. Enable this when running replicated kar-scheduler for high availability.") | |||
| fs.StringVar(&s.LockObjectNamespace, "lock-object-namespace", s.LockObjectNamespace, "Define the namespace of the lock object.") | |||
| fs.BoolVar(&s.PrintVersion, "version", false, "Show version and quit") | |||
k82cn
reviewed
Apr 9, 2019
| @@ -19,6 +19,7 @@ import ( | |||
| "fmt" | |||
| "os" | |||
| "time" | |||
| "volcano.sh/volcano/pkg/version" | |||
k82cn
reviewed
Apr 9, 2019
| @@ -19,6 +19,7 @@ import ( | |||
| "fmt" | |||
| "os" | |||
| "time" | |||
| "volcano.sh/volcano/pkg/version" | |||
k82cn
reviewed
Apr 9, 2019
| fmt.Sprintf("Version: %s", Version), | ||
| fmt.Sprintf("Git SHA: %s", GitSHA), | ||
| fmt.Sprintf("Built At: %s", Built), | ||
| fmt.Sprintf("Go Version: %s", runtime.Version()), |
There was a problem hiding this comment.
will that change in different environment?
There was a problem hiding this comment.
no, golang lib is compiled in
jiaxuanzhou
reviewed
May 7, 2019
|
|
||
| if s.PrintVersion { | ||
| version.PrintVersionAndExit() | ||
| os.Exit(0) |
There was a problem hiding this comment.
this line should be removed
|
@TommyLike , please continue your work with new branch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support printing version in scheduler&controller binaries, output as below:
For #77
NOTE: Image TAG should be updated when releasing.