Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register global options when start #99

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Register global options when start #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scheduler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ var logFlushFreq = pflag.Duration("log-flush-frequency", 5*time.Second, "Maximum
func main() {
s := options.NewServerOption()
s.AddFlags(pflag.CommandLine)
s.RegisterOptions()

flag.InitFlags()
if err := s.CheckOptionOrDie(); err != nil {
Expand Down
11 changes: 0 additions & 11 deletions hack/.golint_failures
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,4 @@ volcano.sh/volcano/pkg/controllers/job/plugins/env
volcano.sh/volcano/pkg/controllers/job/plugins/interface
volcano.sh/volcano/pkg/controllers/job/plugins/ssh
volcano.sh/volcano/pkg/controllers/job/state
volcano.sh/volcano/pkg/scheduler/actions/allocate
volcano.sh/volcano/pkg/scheduler/actions/backfill
volcano.sh/volcano/pkg/scheduler/actions/preempt
volcano.sh/volcano/pkg/scheduler/actions/reclaim
volcano.sh/volcano/pkg/scheduler/plugins/conformance
volcano.sh/volcano/pkg/scheduler/plugins/drf
volcano.sh/volcano/pkg/scheduler/plugins/gang
volcano.sh/volcano/pkg/scheduler/plugins/predicates
volcano.sh/volcano/pkg/scheduler/plugins/priority
volcano.sh/volcano/pkg/scheduler/plugins/proportion
volcano.sh/volcano/pkg/scheduler/util
volcano.sh/volcano/test/e2e