Get rid of mockito

volodya-lombrozo · Aug 2, 2023 · 0a3b421 · 0a3b421
1 parent 10fb133
commit 0a3b421
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 17 deletions.
diff --git a/pom.xml b/pom.xml
@@ -112,12 +112,6 @@ SOFTWARE.
       <version>5.10.0</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.mockito</groupId>
-      <artifactId>mockito-core</artifactId>
-      <version>5.4.0</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>com.jcabi</groupId>
       <artifactId>jcabi-matchers</artifactId>

diff --git a/src/main/java/com/github/lombrozo/testnames/rules/RuleAssertTrueHitter.java b/src/main/java/com/github/lombrozo/testnames/rules/RuleAssertTrueHitter.java
@@ -74,12 +74,8 @@ public Collection<Complaint> complaints() {
      * @return True if contains line hitter
      */
     private Boolean containsLineHitter() {
-        boolean result = false;
-        if (!this.test.assertions().isEmpty()) {
-            result = this.test.assertions()
-                .stream()
-                .anyMatch(Assertion::isLineHitter);
-        }
-        return result;
+        return this.test.assertions()
+            .stream()
+            .anyMatch(Assertion::isLineHitter);
     }
 }
diff --git a/src/test/java/com/github/lombrozo/testnames/rules/RuleAssertTrueHitterTest.java b/src/test/java/com/github/lombrozo/testnames/rules/RuleAssertTrueHitterTest.java
@@ -28,7 +28,6 @@
 import org.hamcrest.MatcherAssert;
 import org.hamcrest.Matchers;
 import org.junit.jupiter.api.Test;
-import org.mockito.Mockito;
 
 /**
  * Test case for {@link RuleAssertTrueHitter}.
@@ -54,12 +53,15 @@ void checksClassWithoutHitterCorrectly() {
     @SuppressWarnings("PMD.JUnitTestContainsTooManyAsserts")
     @Test
     void checksClassWithHitterCorrectly() {
-        final Assertion assertion = Mockito.mock(Assertion.class);
-        Mockito.when(assertion.isLineHitter()).thenReturn(true);
         MatcherAssert.assertThat(
             "Test class with line hitter should have complaints",
             new RuleAssertTrueHitter(
-                new TestCase.Fake(assertion)
+                new TestCase.Fake(
+                    new Assertion.Fake(
+                        "msg",
+                        true
+                    )
+                )
             ).complaints(),
             Matchers.hasSize(1)
         );