Merge branch '__rultor'

pom.xml

@@ -211,7 +211,7 @@ SOFTWARE.
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
-            <version>0.22.0</version>
+            <version>0.22.2</version>
             <configuration>
               <license>file:${basedir}/LICENSE.txt</license>
               <excludes>

src/main/java/com/github/lombrozo/testnames/Complaint.java

@@ -42,24 +42,24 @@ public interface Complaint {
      * Text complaint.
      * @since 0.2
      */
-    class Text implements Complaint {
+    final class Text implements Complaint {
 
         /**
          * Complaint message.
          */
-        private final String text;
+        private final String msg;
 
         /**
          * Main constructor.
          * @param message Complaint message.
          */
         public Text(final String message) {
-            this.text = message;
+            this.msg = message;
         }
 
         @Override
         public String message() {
-            return this.text;
+            return this.msg;
         }
     }
 }

src/main/java/com/github/lombrozo/testnames/Project.java

@@ -125,7 +125,7 @@ public Collection<TestClass> testClasses() {
      *
      * @since 0.1.17
      */
-    class Combined implements Project {
+    final class Combined implements Project {
 
         /**
          * All projects.
@@ -170,7 +170,8 @@ public Collection<TestClass> testClasses() {
      *
      * @since 1.0.1
      */
-    class WithoutTests implements Project {
+    @SuppressWarnings("PMD.TestClassWithoutTestCases")
+    final class WithoutTests implements Project {
 
         /**
          * Original project.

src/main/java/com/github/lombrozo/testnames/TestCase.java

@@ -61,6 +61,7 @@ public interface TestCase {
      * @since 0.1.0
      */
     @Data
+    @SuppressWarnings("PMD.TestClassWithoutTestCases")
     final class Fake implements TestCase {
 
         /**

src/main/java/com/github/lombrozo/testnames/TestClassCharacteristics.java

@@ -183,6 +183,7 @@ public String parent() {
      */
     @EqualsAndHashCode
     @ToString
+    @SuppressWarnings("PMD.TestClassWithoutTestCases")
     final class IntegrationTest implements TestClassCharacteristics {
 
         @Override

src/main/java/com/github/lombrozo/testnames/javaparser/JavaParserTestCase.java

@@ -41,6 +41,7 @@
  * @since 0.1.0
  */
 @Data
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 final class JavaParserTestCase implements TestCase {
 
     /**

src/main/java/com/github/lombrozo/testnames/javaparser/TestsOnly.java

@@ -32,7 +32,11 @@
  *
  * @since 0.1.15
  */
-@SuppressWarnings("PMD.JUnit4TestShouldUseTestAnnotation")
+@SuppressWarnings({
+    "PMD.JUnit4TestShouldUseTestAnnotation",
+    "PMD.JUnitTestsShouldIncludeAssert",
+    "PMD.TestClassWithoutTestCases"
+})
 final class TestsOnly implements Predicate<MethodDeclaration> {
 
     @Override

src/main/java/com/github/lombrozo/testnames/rules/RuleCorrectTestCase.java

@@ -36,6 +36,7 @@
  *
  * @since 0.1.0
  */
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public final class RuleCorrectTestCase implements Rule {
 
     /**

src/main/java/com/github/lombrozo/testnames/rules/RuleCorrectTestCases.java

@@ -38,6 +38,7 @@
  *
  * @since 0.1.0
  */
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public final class RuleCorrectTestCases implements Rule {
 
     /**

src/main/java/com/github/lombrozo/testnames/rules/RuleInheritanceInTests.java

@@ -34,6 +34,7 @@
  * The rule that checks a test class doesn't use inheritance.
  * @since 1.2.0
  */
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public final class RuleInheritanceInTests implements Rule {
 
     /**
@@ -53,7 +54,7 @@ public RuleInheritanceInTests(final TestClass clazz) {
     public Collection<Complaint> complaints() {
         final Collection<Complaint> result;
         final String parent = this.clazz.characteristics().parent();
-        if (parent.equals("java.lang.Object")) {
+        if ("java.lang.Object".equals(parent)) {
             result = Collections.emptyList();
         } else {
             result = Collections.singleton(

src/test/java/com/github/lombrozo/testnames/CopTest.java

@@ -32,7 +32,7 @@
  *
  * @since 0.2
  */
-class CopTest {
+final class CopTest {
 
     @Test
     void checksSuccessfully() {

src/test/java/com/github/lombrozo/testnames/ProjectTest.java

@@ -32,7 +32,7 @@
  *
  * @since 0.1.17
  */
-class ProjectTest {
+final class ProjectTest {
 
     @Test
     void createsCombinedProject() {

src/test/java/com/github/lombrozo/testnames/ProjectWithoutJUnitExtensionsTest.java

@@ -34,7 +34,7 @@
  *
  * @since 0.1.17
  */
-class ProjectWithoutJUnitExtensionsTest {
+final class ProjectWithoutJUnitExtensionsTest {
 
     @Test
     void returnsProductionClassesFromOrigin() {

src/test/java/com/github/lombrozo/testnames/bytecode/BytecodeProjectTest.java

@@ -41,7 +41,7 @@
  *
  * @since 0.1.17
  */
-class BytecodeProjectTest {
+final class BytecodeProjectTest {
 
     @Test
     @SuppressWarnings("JTCOP.RuleNotContainsTestWord")

src/test/java/com/github/lombrozo/testnames/bytecode/BytecodeTestClassTest.java

@@ -38,7 +38,7 @@
  *
  * @since 0.1.17
  */
-class BytecodeTestClassTest {
+final class BytecodeTestClassTest {
 
     @Test
     void checksIfBytecodeIsJUnitExtension(@TempDir final Path temp) throws Exception {

src/test/java/com/github/lombrozo/testnames/complaints/ComplaintClassTest.java

@@ -33,7 +33,7 @@
  * Test cases for {@link ComplaintClass}.
  * @since 0.2
  */
-class ComplaintClassTest {
+final class ComplaintClassTest {
 
     @Test
     void returnsSimpleMessageIfDoesNotHaveComplaints() {

src/test/java/com/github/lombrozo/testnames/complaints/ComplaintWrongTestNameTest.java

@@ -33,7 +33,7 @@
  *
  * @since 0.2
  */
-class ComplaintWrongTestNameTest {
+final class ComplaintWrongTestNameTest {
 
     @Test
     void buildsMessage() {

src/test/java/com/github/lombrozo/testnames/javaparser/AssertionOfHamcrestTest.java

@@ -37,7 +37,7 @@
  *
  * @since 0.1.15
  */
-class AssertionOfHamcrestTest {
+final class AssertionOfHamcrestTest {
 
     @Test
     void parsesAllHamcrestAssertions() {

src/test/java/com/github/lombrozo/testnames/javaparser/AssertionOfJUnitTest.java

@@ -37,7 +37,7 @@
  *
  * @since 0.1.15
  */
-class AssertionOfJUnitTest {
+final class AssertionOfJUnitTest {
 
     /**
      * Method name for test with messages.

src/test/java/com/github/lombrozo/testnames/javaparser/JavaParserAssertionTest.java

@@ -35,7 +35,7 @@
  *
  * @since 0.1.15
  */
-class JavaParserAssertionTest {
+final class JavaParserAssertionTest {
 
     /**
      * Expectation message for the tests that check the number of assertions.

src/test/java/com/github/lombrozo/testnames/javaparser/JavaParserProductionClassTest.java

@@ -33,7 +33,7 @@
  *
  * @since 0.2
  */
-class JavaParserProductionClassTest {
+final class JavaParserProductionClassTest {
 
     @Test
     void returnsName() {

src/test/java/com/github/lombrozo/testnames/javaparser/JavaParserTestCaseTest.java

@@ -40,7 +40,8 @@
  *
  * @since 0.2
  */
-class JavaParserTestCaseTest {
+@SuppressWarnings("PMD.TooManyMethods")
+final class JavaParserTestCaseTest {
 
     @Test
     void convertsToString() {

src/test/java/com/github/lombrozo/testnames/javaparser/JavaParserTestClassTest.java

@@ -45,6 +45,7 @@
  *
  * @since 0.1.0
  */
+@SuppressWarnings("PMD.TooManyMethods")
 final class JavaParserTestClassTest {
 
     @Test

src/test/java/com/github/lombrozo/testnames/rules/LineHitterRuleTest.java

@@ -34,7 +34,7 @@
  *
  * @since 1.0.1
  */
-class LineHitterRuleTest {
+final class LineHitterRuleTest {
 
     @Test
     void checksClassWithoutHitterCorrectly() {

src/test/java/com/github/lombrozo/testnames/rules/RuleAssertionMessageTest.java

@@ -36,7 +36,7 @@
  *
  * @since 0.1.15
  */
-class RuleAssertionMessageTest {
+final class RuleAssertionMessageTest {
 
     @Test
     void checksAssertionMessageWithoutComplaints() {

src/test/java/com/github/lombrozo/testnames/rules/RuleCorrectTestNameTest.java

@@ -35,7 +35,7 @@
  *
  * @since 0.1.17
  */
-class RuleCorrectTestNameTest {
+final class RuleCorrectTestNameTest {
 
     @Test
     void createsCorrectly() {

src/test/java/com/github/lombrozo/testnames/rules/RuleInheritanceInTestsTest.java

@@ -33,7 +33,7 @@
  * Test cases for {@link RuleInheritanceInTests}.
  * @since 1.2
  */
-class RuleInheritanceInTestsTest {
+final class RuleInheritanceInTestsTest {
 
     @Test
     void doesNotFoundParents() {

src/test/java/com/github/lombrozo/testnames/rules/RuleNotContainsTestWordTest.java

@@ -36,7 +36,7 @@
  * Test for {@link RuleNotContainsTestWord}.
  * @since 0.2.0
  */
-class RuleNotContainsTestWordTest {
+final class RuleNotContainsTestWordTest {
 
     @ParameterizedTest
     @MethodSource("cases")

src/test/java/com/github/lombrozo/testnames/rules/RuleOnlyTestMethodsTest.java

@@ -34,7 +34,7 @@
  *
  * @since 0.1.19
  */
-class RuleOnlyTestMethodsTest {
+final class RuleOnlyTestMethodsTest {
 
     @Test
     void checksClassCorrectly() {

src/test/java/com/github/lombrozo/testnames/rules/ml/ModelSourceFileSystemTest.java

@@ -40,7 +40,7 @@
  *  every-day development.
  */
 @Disabled
-class ModelSourceFileSystemTest {
+final class ModelSourceFileSystemTest {
 
     @Test
     void loadsFromFileSystem(@TempDir final Path temp) throws IOException {

src/test/java/com/github/lombrozo/testnames/rules/ml/RulePresentSimpleMlTest.java

@@ -39,7 +39,7 @@
  * @since 0.10
  */
 @Disabled
-class RulePresentSimpleMlTest {
+final class RulePresentSimpleMlTest {
 
     /**
      * Model for tests.