feat(#396): fix all qulice offences

src/main/java/com/github/lombrozo/testnames/Cop.java

@@ -46,11 +46,6 @@ final class Cop {
      */
     private final Project project;
 
-    /**
-     * Parameters for rules.
-     */
-    private final Parameters parameters;
-
     /**
      * The law to check the project.
      */
@@ -81,23 +76,8 @@ final class Cop {
     Cop(
         final Project project,
         final Function<Suspect, Stream<Rule>> law
-    ) {
-        this(project, new Parameters(), law);
-    }
-
-    /**
-     * Ctor.
-     * @param project The project to check.
-     * @param parameters Parameters for rules.
-     * @param law The law to check the project.
-     */
-    private Cop(
-        final Project project,
-        final Parameters parameters,
-        final Function<Suspect, Stream<Rule>> law
     ) {
         this.project = project;
-        this.parameters = parameters;
         this.law = law;
     }
 

src/main/java/com/github/lombrozo/testnames/Parameters.java

@@ -62,9 +62,7 @@ private Parameters(final Map<String, ?> params) {
      */
     public OptionalInt intValue(final String name) {
         final OptionalInt result;
-        if (!this.params.containsKey(name)) {
-            result = OptionalInt.empty();
-        } else {
+        if (this.params.containsKey(name)) {
             final Object value = this.params.get(name);
             if (!(value instanceof Integer)) {
                 throw new IllegalArgumentException(
@@ -74,6 +72,8 @@ public OptionalInt intValue(final String name) {
                 );
             }
             result = OptionalInt.of(Integer.class.cast(value));
+        } else {
+            result = OptionalInt.empty();
         }
         return result;
     }
@@ -83,13 +83,13 @@ public OptionalInt intValue(final String name) {
      * @param params Parameters pairs like "name", "value", "name2", "value2".
      * @return Map.
      */
-    private static Map<String, ?> fromArray(final Object[] params) {
+    private static Map<String, ?> fromArray(final Object... params) {
         if (params.length % 2 != 0) {
             throw new IllegalArgumentException("Parameters list should be even");
         }
         final Map<String, Object> res = new HashMap<>(0);
-        for (int i = 0; i < params.length; i += 2) {
-            res.put((String) params[i], params[i + 1]);
+        for (int index = 0; index < params.length; index += 2) {
+            res.put((String) params[index], params[index + 1]);
         }
         return res;
     }

src/test/java/com/github/lombrozo/testnames/ParametersTest.java

@@ -67,4 +67,4 @@ void findsNoValue() {
             Matchers.is(false)
         );
     }
-}
+}