Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#353): Consider Inner Blocks During Statements Scan #354

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

volodya-lombrozo
Copy link
Owner

@volodya-lombrozo volodya-lombrozo commented Apr 17, 2024

In this PR, I fixed the problem related to missed assertions. The problem occurred when we had inner blocks with inner statements. Now we consider all statements.

Closes: #353.
History:


PR-Codex overview

The focus of this PR is to enhance Java test parsing capabilities by adding support for assertions inside loops.

Detailed summary

  • Added a new test case for parsing assertions inside a loop
  • Updated the JavaParserMethod class to unroll inner method statements
  • Modified test methods to accommodate new functionality

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 17, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b1258b7 into main Apr 17, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Apr 17, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 5min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuleAssertionMessage ignores the assertion inside the loop
2 participants