Partially working example of getting volo.url from package.json for private repos #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be used for downloading.
… in package.json. Does NOT work - even if we get the URL, which we can, still must download that file. Going to suggest using volo commands after a full download to strip out all contents but what is specified.
|
Related to #156. We talked a bit in person, so I think we ironed out some details on the approach. On this pull request, it looks like a lot has changed in the file, but I suspect some of it is just whitespace changes. So when looking at another pull request, try to limit the changes to code changes, or if there is an issue with the repo setup, let me know so we can avoid wading through whitespace changes. Going to close this pull request for now, in favor of doing the full approach we talked about in person, and we will track that work with #156. |
|
Apologies - we have present style at work and I always forget to turn that off in my editor when doing pull request changes. I updated #156 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the package.json works, but may not be idea. May be preferred to just leave existing code as is but add a flag to indicate no package.json could be fetched. Then once the file is downloaded, parse package.json and use volo commands to delete all but the requested file.
I'd be happy to do some of this if you indicate a preferred direction.