Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsLifetimeScope disposing fix #25

Closed
wants to merge 1 commit into from
Closed

MsLifetimeScope disposing fix #25

wants to merge 1 commit into from

Conversation

pecanw
Copy link

@pecanw pecanw commented Dec 21, 2017

In some scenarios (namely using TypedFactoryFacility and resolving scoped component using Func) failed due to a missing MsLifetimeScope.Current which was released too early.

If you wish to add a test for this scenario please feel free to get it from my ContainerTest.

@acjh
Copy link

acjh commented Dec 21, 2017

You can include the test in this PR for regression testing.

@hikalkan
Copy link
Member

@pecanw we will be very happy if you can add test yourself as @acjh stated.

@hikalkan hikalkan modified the milestones: v3.3.0, v3.4 Dec 21, 2017
@jirikanda jirikanda mentioned this pull request Feb 15, 2019
Open
@hikalkan hikalkan modified the milestones: v3.4, v3.5 Aug 19, 2020
@ismcagdas ismcagdas modified the milestones: v4.0, v4.2 Nov 18, 2023
@enisn enisn requested a review from maliming November 22, 2023 10:09
@maliming maliming removed their request for review November 23, 2023 00:50
@maliming maliming removed this from the v4.2 milestone Nov 23, 2023
@maliming maliming closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pecanw @acjh @hikalkan @ismcagdas @maliming