Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace atty with is-terminal #1508

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented May 5, 2023

Replaces atty with is-terminal as the former is unmaintained.

@chriskrycho
Copy link
Contributor

Thanks for opening this! A couple notes:

  1. I don't see any actual explicit indication on the repo that is-terminal is unmaintained, only a recommendation that folks use the Rust built-in post-1.70. Do you have some further info?
  2. We're currently evaluating our MSRV, and if we bump it to a more recent version it's very likely we will just do exactly what is-terminal recommends and use the thing Rust ships.

@chriskrycho chriskrycho added Awaiting more info The issue requires more information from whoever filed it dependencies Pull requests that update a dependency file labels Dec 19, 2023
@chriskrycho
Copy link
Contributor

Oh! I see, I read this backwards; you're wanting to move this from atty to is-terminal. I think the same basic question applies, and in general I would not be worried by something having gone without an update for a while… but seeing as atty has a known soundness issue, I'm strongly in support here. I will rebase this and get it merged. Thanks!

@chriskrycho chriskrycho removed the Awaiting more info The issue requires more information from whoever filed it label Dec 19, 2023
Resolve the merge conflict by recreating the lock file update.
@chriskrycho chriskrycho merged commit eace466 into volta-cli:main Dec 19, 2023
10 of 11 checks passed
@tottoto tottoto deleted the replace-atty-with-is-terminal branch December 19, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants