[Large] Add support for inheriting platforms (monorepos) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespierce
force-pushed
the
workspace_support
branch
from
ddd8acc to
d783510
Compare
charlespierce
changed the title
charlespierce
changed the title
charlespierce
force-pushed
the
workspace_support
branch
from
d783510 to
0657535
Compare
This was referenced Jun 5, 2020
charlespierce
force-pushed
the
workspace_support
branch
from
0657535 to
17430f0
Compare
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
|
Published the |
chriskrycho
approved these changes
Jun 9, 2020
Comment on lines
+125
to
+128
| ExtensionCycleError { | ||
| paths: Vec<PathBuf>, | ||
| duplicate: PathBuf, | ||
| }, |
Comment on lines
+703
to
+709
| // Detected infinite loop in project workspace: | ||
| // | ||
| // --> /home/user/workspace/project/package.json | ||
| // /home/user/workspace/package.json | ||
| // --> /home/user/workspace/project/package.json | ||
| // | ||
| // Please ensure that project workspaces do not depend on each other. |
| @@ -155,6 +155,7 @@ impl<T> Default for InheritOption<T> { | |||
| } | |||
|
|
|||
| #[derive(Clone, PartialOrd, Ord, PartialEq, Eq)] | |||
| #[cfg_attr(test, derive(Debug))] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378
Implements volta-cli/rfcs#43
Info
extendskey inpackage.jsonVolta settings (see the above-linked RFC for more information).Changes
chain-mapcrate, an abstraction to allow searching a chain ofHashMaps without having to collapse all of them into a single map.project, instead of a separatemanifestmodule.Projecttype to support pulling data from multiple sources by following a chain ofextendsdirectives.ChainMap, as we only need to search through them to determine if a dependency is there or not, we don't need to iterate / process the entire list.PlatformSpeconce all files are loaded. This will throw a more helpful error when there isn't a Node version (previously it would be an obaque parsing error because we requirednodeto be set ifvoltawas present).package.jsonto avoid clobbering anyextendssettings.manifest/tests.rsfile.Tested
extendschain.extendsworks as expected.Notes
project.rswas moved intoproject/mod.rswith other submodules inproject/. This has the unfortunate side effect of the diff looking likeproject.rswas deleted andproject.mod.rswas created. While there are substantial changes, the code isn't 100% unique.manifest/mod.rstoproject/serial.rs, with some modifications to support the new format. This again looks like mass removal / insertion.chain-mapWill likely be refactored and actually published on crates.io, so it won't have to remain a child crate permanently.