Revert "Dealing with trailing whitespaces"

The validation script from moby#10681 is too pedantic, and does not handle
well situations like:

```
cat <<EOF   # or <<-EOF
	Whether the leading whitespace is stripped out or not by bash
	it should still be considered as valid.
EOF
```

This reverts commit 4e65c1c.

Signed-off-by: Tibor Vass <tibor@docker.com>

MAINTAINERS

@@ -113,7 +113,7 @@ It is the responsibility of the subsystem maintainers to process patches affecti
 manner.
 
 * If the change affects areas of the code which are not part of a subsystem,
-or if subsystem maintainers are unable to reach a timely decision, it must be approved by
+or if subsystem maintainers are unable to reach a timely decision, it must be approved by 
 the core maintainers.
 
 * If the change affects the UI or public APIs, or if it represents a major change in architecture,
@@ -200,11 +200,11 @@ for each.
 			2-code-review = "requires more code changes"
 			1-design-review = "raises design concerns"
 			4-merge = "general case"
-
+			
 		# Docs approval
 		[Rules.review.docs-approval]
 			# Changes and additions to docs must be reviewed and approved (LGTM'd) by a minimum of two docs sub-project maintainers.
-			# If the docs change originates with a docs maintainer, only one additional LGTM is required (since we assume a docs maintainer approves of their own PR).
+			# If the docs change originates with a docs maintainer, only one additional LGTM is required (since we assume a docs maintainer approves of their own PR). 	
 
 		# Merge
 		[Rules.review.states.4-merge]
@@ -268,7 +268,7 @@ made through a pull request.
 
 	# The chief architect is responsible for the overall integrity of the technical architecture
 	# across all subsystems, and the consistency of APIs and UI.
-	#
+	# 
 	# Changes to UI, public APIs and overall architecture (for example a plugin system) must
 	# be approved by the chief architect.
 	"Chief Architect" = "shykes"
@@ -314,7 +314,7 @@ made through a pull request.
 			]
 
 	# The chief maintainer is responsible for all aspects of quality for the project including
-	# code reviews, usability, stability, security, performance, etc.
+	# code reviews, usability, stability, security, performance, etc. 
 	# The most important function of the chief maintainer is to lead by example. On the first
 	# day of a new maintainer, the best advice should be "follow the C.M.'s example and you'll
 	# be fine".
@@ -359,9 +359,9 @@ made through a pull request.
 	# has a dedicated group of maintainers, which are dedicated to that subsytem and responsible
 	# for its quality.
 	# This "cellular division" is the primary mechanism for scaling maintenance of the project as it grows.
-	#
+	# 
 	# The maintainers of each subsytem are responsible for:
-	#
+	# 
 	# 1. Exposing a clear road map for improving their subsystem.
 	# 2. Deliver prompt feedback and decisions on pull requests affecting their subsystem.
 	# 3. Be available to anyone with questions, bug reports, criticism etc.
@@ -371,9 +371,9 @@ made through a pull request.
 	#   road map of the project.
 	#
 	# #### How to review patches to your subsystem
-	#
+	# 
 	# Accepting pull requests:
-	#
+	# 
 	#   - If the pull request appears to be ready to merge, give it a `LGTM`, which
 	#     stands for "Looks Good To Me".
 	#   - If the pull request has some small problems that need to be changed, make
@@ -384,9 +384,9 @@ made through a pull request.
 	#   - If the PR only needs a few changes before being merged, any MAINTAINER can
 	#     make a replacement PR that incorporates the existing commits and fixes the
 	#     problems before a fast track merge.
-	#
+	# 
 	# Closing pull requests:
-	#
+	# 
 	#   - If a PR appears to be abandoned, after having attempted to contact the
 	#     original contributor, then a replacement PR may be made.  Once the
 	#     replacement PR is made, any contributor may close the original one.
@@ -584,12 +584,12 @@ made through a pull request.
 	Name = "Solomon Hykes"
 	Email = "solomon@docker.com"
 	GitHub = "shykes"
-
+    
 	[people.spf13]
 	Name = "Steve Francia"
 	Email = "steve.francia@gmail.com"
 	GitHub = "spf13"
-
+	
 	[people.sven]
 	Name = "Sven Dowideit"
 	Email = "SvenDowideit@home.org.au"

Makefile

@@ -77,7 +77,7 @@ test-docker-py: build
 	$(DOCKER_RUN_DOCKER) hack/make.sh binary test-docker-py
 
 validate: build
-	$(DOCKER_RUN_DOCKER) hack/make.sh validate-gofmt validate-dco validate-toml validate-spaces
+	$(DOCKER_RUN_DOCKER) hack/make.sh validate-gofmt validate-dco validate-toml
 
 shell: build
 	$(DOCKER_RUN_DOCKER) bash

NOTICE

@@ -10,9 +10,9 @@ The following is courtesy of our legal counsel:
 
 
 Use and transfer of Docker may be subject to certain restrictions by the
-United States and other governments.
+United States and other governments.  
 It is your responsibility to ensure that your use and/or transfer does not
-violate applicable laws.
+violate applicable laws. 
 
 For more information, please see http://www.bis.doc.gov
 

contrib/completion/bash/docker

@@ -22,7 +22,7 @@
 # must have access to the socket for the completions to function correctly
 #
 # Note for developers:
-# Please arrange options sorted alphabetically by long name with the short
+# Please arrange options sorted alphabetically by long name with the short 
 # options immediately following their corresponding long form.
 # This order should be applied to lists, alternatives and code blocks.
 
@@ -257,8 +257,8 @@ _docker_build() {
 			;;
 		--file|-f)
 			_filedir
-			return
-			;;
+			return	
+			;;	
 	esac
 
 	case "$cur" in

contrib/desktop-integration/gparted/Dockerfile

@@ -3,7 +3,7 @@
 # AUTHOR:         Jessica Frazelle <jess@docker.com>
 # COMMENTS:
 #   This file describes how to build a gparted container with all
-#   dependencies installed. It uses native X11 unix socket.
+#   dependencies installed. It uses native X11 unix socket. 
 #   Tested on Debian Jessie
 # USAGE:
 #   # Download gparted Dockerfile

contrib/host-integration/manager/systemd

@@ -10,11 +10,11 @@ cat <<-EOF
 	Description=$desc
 	Author=$auth
 	After=docker.service
-
+	
 	[Service]
 	ExecStart=/usr/bin/docker start -a $cid
 	ExecStop=/usr/bin/docker stop -t 2 $cid
-
+	
 	[Install]
 	WantedBy=local.target
 EOF

contrib/init/sysvinit-redhat/docker.sysconfig

@@ -1,5 +1,5 @@
 # /etc/sysconfig/docker
-#
+# 
 # Other arguments to pass to the docker daemon process
 # These will be parsed by the sysv initscript and appended
 # to the arguments list passed to docker -d

contrib/mkimage-debootstrap.sh

@@ -14,9 +14,9 @@ justTar=
 
 usage() {
 	echo >&2
-
+	
 	echo >&2 "usage: $0 [options] repo suite [mirror]"
-
+	
 	echo >&2
 	echo >&2 'options: (not recommended)'
 	echo >&2 "  -p set an http_proxy for debootstrap"
@@ -26,20 +26,20 @@ usage() {
 	echo >&2 "  -s # skip version detection and tagging (ie, precise also tagged as 12.04)"
 	echo >&2 "     # note that this will also skip adding universe and/or security/updates to sources.list"
 	echo >&2 "  -t # just create a tarball, especially for dockerbrew (uses repo as tarball name)"
-
+	
 	echo >&2
 	echo >&2 "   ie: $0 username/debian squeeze"
 	echo >&2 "       $0 username/debian squeeze http://ftp.uk.debian.org/debian/"
-
+	
 	echo >&2
 	echo >&2 "   ie: $0 username/ubuntu precise"
 	echo >&2 "       $0 username/ubuntu precise http://mirrors.melbourne.co.uk/ubuntu/"
-
+	
 	echo >&2
 	echo >&2 "   ie: $0 -t precise.tar.bz2 precise"
 	echo >&2 "       $0 -t wheezy.tgz wheezy"
 	echo >&2 "       $0 -t wheezy-uk.tar.xz wheezy http://ftp.uk.debian.org/debian/"
-
+	
 	echo >&2
 }
 
@@ -145,10 +145,10 @@ if [ -z "$strictDebootstrap" ]; then
 	sudo chroot . dpkg-divert --local --rename --add /sbin/initctl
 	sudo ln -sf /bin/true sbin/initctl
 	# see https://github.com/docker/docker/issues/446#issuecomment-16953173
-
+	
 	# shrink the image, since apt makes us fat (wheezy: ~157.5MB vs ~120MB)
 	sudo chroot . apt-get clean
-
+	
 	if strings usr/bin/dpkg | grep -q unsafe-io; then
 		# while we're at it, apt is unnecessarily slow inside containers
 		#  this forces dpkg not to call sync() after package extraction and speeds up install
@@ -159,25 +159,25 @@ if [ -z "$strictDebootstrap" ]; then
 		# (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=584254#82),
 		# and ubuntu lucid/10.04 only has 1.15.5.6
 	fi
-
+	
 	# we want to effectively run "apt-get clean" after every install to keep images small (see output of "apt-get clean -s" for context)
 	{
 		aptGetClean='"rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true";'
 		echo "DPkg::Post-Invoke { ${aptGetClean} };"
 		echo "APT::Update::Post-Invoke { ${aptGetClean} };"
 		echo 'Dir::Cache::pkgcache ""; Dir::Cache::srcpkgcache "";'
 	} | sudo tee etc/apt/apt.conf.d/no-cache > /dev/null
-
+	
 	# and remove the translations, too
 	echo 'Acquire::Languages "none";' | sudo tee etc/apt/apt.conf.d/no-languages > /dev/null
-
+	
 	# helpful undo lines for each the above tweaks (for lack of a better home to keep track of them):
 	#  rm /usr/sbin/policy-rc.d
 	#  rm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl
 	#  rm /etc/dpkg/dpkg.cfg.d/02apt-speedup
 	#  rm /etc/apt/apt.conf.d/no-cache
 	#  rm /etc/apt/apt.conf.d/no-languages
-
+	
 	if [ -z "$skipDetection" ]; then
 		# see also rudimentary platform detection in hack/install.sh
 		lsbDist=''
@@ -187,14 +187,14 @@ if [ -z "$strictDebootstrap" ]; then
 		if [ -z "$lsbDist" ] && [ -r etc/debian_version ]; then
 			lsbDist='Debian'
 		fi
-
+		
 		case "$lsbDist" in
 			Debian)
 				# add the updates and security repositories
 				if [ "$suite" != "$debianUnstable" -a "$suite" != 'unstable' ]; then
 					# ${suite}-updates only applies to non-unstable
 					sudo sed -i "p; s/ $suite main$/ ${suite}-updates main/" etc/apt/sources.list
-
+					
 					# same for security updates
 					echo "deb http://security.debian.org/ $suite/updates main" | sudo tee -a etc/apt/sources.list > /dev/null
 				fi
@@ -220,7 +220,7 @@ if [ -z "$strictDebootstrap" ]; then
 				;;
 		esac
 	fi
-
+	
 	# make sure our packages lists are as up to date as we can get them
 	sudo chroot . apt-get update
 	sudo chroot . apt-get dist-upgrade -y
@@ -229,23 +229,23 @@ fi
 if [ "$justTar" ]; then
 	# create the tarball file so it has the right permissions (ie, not root)
 	touch "$repo"
-
+	
 	# fill the tarball
 	sudo tar --numeric-owner -caf "$repo" .
 else
 	# create the image (and tag $repo:$suite)
 	sudo tar --numeric-owner -c . | $docker import - $repo:$suite
-
+	
 	# test the image
 	$docker run -i -t $repo:$suite echo success
-
+	
 	if [ -z "$skipDetection" ]; then
 		case "$lsbDist" in
 			Debian)
 				if [ "$suite" = "$debianStable" -o "$suite" = 'stable' ] && [ -r etc/debian_version ]; then
 					# tag latest
 					$docker tag $repo:$suite $repo:latest
-
+					
 					if [ -r etc/debian_version ]; then
 						# tag the specific debian release version (which is only reasonable to tag on debian stable)
 						ver=$(cat etc/debian_version)

contrib/report-issue.sh

@@ -29,41 +29,41 @@ function template() {
 # this should always match the template from CONTRIBUTING.md
 	cat <<- EOM
 	Description of problem:
-
-
+	
+	
 	\`docker version\`:
 	`${DOCKER_COMMAND} -D version`
-
-
+	
+	
 	\`docker info\`:
 	`${DOCKER_COMMAND} -D info`
-
-
+	
+	
 	\`uname -a\`:
 	`uname -a`
-
-
+	
+	
 	Environment details (AWS, VirtualBox, physical, etc.):
-
-
+	
+	
 	How reproducible:
-
-
+	
+	
 	Steps to Reproduce:
 	1.
 	2.
 	3.
-
-
+	
+	
 	Actual Results:
-
-
+	
+	
 	Expected Results:
-
-
+	
+	
 	Additional info:
-
-
+	
+	
 	EOM
 }
 
@@ -81,7 +81,7 @@ echo -ne "Do you use \`sudo\` to call docker? [y|N]: "
 read -r -n 1 use_sudo
 echo ""
 
-if [ "x${use_sudo}" = "xy" -o "x${use_sudo}" = "xY" ]; then
+if [ "x${use_sudo}" = "xy" -o "x${use_sudo}" = "xY" ]; then 
 	export DOCKER_COMMAND="sudo ${DOCKER}"
 fi
 

docs/sources/examples/postgresql_service.Dockerfile

@@ -6,7 +6,7 @@ FROM ubuntu
 MAINTAINER SvenDowideit@docker.com
 
 # Add the PostgreSQL PGP key to verify their Debian packages.
-# It should be the same key as https://www.postgresql.org/media/keys/ACCC4CF8.asc
+# It should be the same key as https://www.postgresql.org/media/keys/ACCC4CF8.asc 
 RUN apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys B97B0AFCAA1A47F044F244A07FCC7D46ACCC4CF8
 
 # Add PostgreSQL's repository. It contains the most recent stable release
@@ -33,7 +33,7 @@ RUN    /etc/init.d/postgresql start &&\
     createdb -O docker docker
 
 # Adjust PostgreSQL configuration so that remote connections to the
-# database are possible.
+# database are possible. 
 RUN echo "host all  all    0.0.0.0/0  md5" >> /etc/postgresql/9.3/main/pg_hba.conf
 
 # And add ``listen_addresses`` to ``/etc/postgresql/9.3/main/postgresql.conf``

hack/make.sh

@@ -45,7 +45,6 @@ DEFAULT_BUNDLES=(
 	validate-dco
 	validate-gofmt
 	validate-toml
-	validate-spaces
 
 	binary