Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Fix name from beadmass inference #378

Merged
merged 5 commits into from
Aug 12, 2021
Merged

Fix name from beadmass inference #378

merged 5 commits into from
Aug 12, 2021

Conversation

JensWehner
Copy link
Member

No description provided.

@JensWehner
Copy link
Member Author

@votca-bot changelog: changed tolerance for getting element names from mass

@junghans
Copy link
Member

junghans commented Aug 5, 2021

Shouldn't that go into stable instead?

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #378 (6803ffd) into stable (6dcb179) will increase coverage by 3.2%.
The diff coverage is 87.5%.

❗ Current head 6803ffd differs from pull request most recent head add6ee0. Consider uploading reports for the commit add6ee0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           stable    #378     +/-   ##
========================================
+ Coverage    78.0%   81.3%   +3.2%     
========================================
  Files          77      77             
  Lines        3531    3594     +63     
========================================
+ Hits         2756    2923    +167     
+ Misses        775     671    -104     
Impacted Files Coverage Δ
include/votca/tools/akimaspline.h 100.0% <ø> (ø)
include/votca/tools/calculator.h 0.0% <0.0%> (-83.4%) ⬇️
include/votca/tools/eigensystem.h 0.0% <0.0%> (-23.1%) ⬇️
include/votca/tools/globals.h 0.0% <ø> (ø)
include/votca/tools/histogram.h 0.0% <0.0%> (ø)
include/votca/tools/linspline.h 100.0% <ø> (ø)
src/libtools/globals.cc 0.0% <ø> (-66.7%) ⬇️
src/libtools/histogram.cc 0.0% <0.0%> (ø)
src/libtools/linalg.cc 94.4% <ø> (-1.4%) ⬇️
include/votca/tools/propertyiomanipulator.h 21.7% <25.0%> (+7.4%) ⬆️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b14db...add6ee0. Read the comment docs.

@JensWehner JensWehner changed the base branch from master to stable August 6, 2021 10:04
@JensWehner JensWehner changed the base branch from stable to master August 6, 2021 10:05
@JensWehner
Copy link
Member Author

@votca-bot format

@JensWehner
Copy link
Member Author

I do not think it can go into stable because I also have to change CSG.

@junghans
Copy link
Member

I do not think it can go into stable because I also have to change CSG.

Why not both?

@JensWehner
Copy link
Member Author

good point

@JensWehner JensWehner force-pushed the ElementNameFromMassFix branch from 6803ffd to 8c10935 Compare August 10, 2021 12:55
@JensWehner JensWehner changed the base branch from master to stable August 10, 2021 12:55
@junghans junghans enabled auto-merge August 12, 2021 22:12
@junghans junghans merged commit 81e2268 into stable Aug 12, 2021
@junghans junghans deleted the ElementNameFromMassFix branch August 12, 2021 23:11
votca-bot added a commit to votca/votca that referenced this pull request Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants