Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reboot to BIOS to vendor menu #400

Merged
merged 2 commits into from
Oct 14, 2024
Merged

add reboot to BIOS to vendor menu #400

merged 2 commits into from
Oct 14, 2024

Conversation

adghayes
Copy link
Contributor

Overview

Adds a reboot to BIOS option to the vendor menu. Tested in my VM. Using the same command we currently use in vxsuite to do the reboot.

Before

Screen Shot 2024-10-10 at 7 55 28 AM

After

Screen Shot 2024-10-10 at 7 54 33 AM

@adghayes
Copy link
Contributor Author

@arsalansufi I think we should rename the whole vx-admin user and config files to use the word vendor, but since the script are referenced I didn't want to dig in too much right now and make a mistake that'll hold up the next build, but I certainly can (it's probably safe, just find and replace)

Copy link
Contributor

@arsalansufi arsalansufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arsalansufi
Copy link
Contributor

Discussed with @adghayes in person and agree with the decision to rename vx-admin vx-vendor! The user is only used to access the basic configuration wizard and the vendor menu, both vendor-specific.

And it'd be nice to better disambiguate VxAdmin the machine from vx-admin the system user

@arsalansufi
Copy link
Contributor

Ticketed: votingworks/vxsuite#5509

@adghayes adghayes merged commit 67127b7 into main Oct 14, 2024
1 check passed
@adghayes adghayes deleted the drew/reboot-to-bios branch October 14, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants