Remove old CVR code from VxAdmin (#3999)

* Remove old-format CVR fixture data

* Indicate which files in libs/fixtures are generated

So that the GitHub UI collapses them by default

* Generate new-format CVR fixture data using libs/cvr-fixture-generator

From libs/cvr-fixture-generator:
$ ./bin/generate \
  -p ../fixtures/data/electionGridLayoutNewHampshireAmherst/election.json \
  -o ../fixtures/data/electionGridLayoutNewHampshireAmherst/castVoteRecords/generated
$ ./bin/generate \
  -p ../fixtures/data/electionTwoPartyPrimary/election.json \
  -o ../fixtures/data/electionTwoPartyPrimary/castVoteRecords/generated

* Add manually prepared new-format CVR fixture data

* Update build_resources.sh in libs/fixtures

* Run `pnpm build:resources` in libs/fixtures

* Update relevant fixtures' index.ts files

* Delete legacy_import.test.ts

Since it relies on old CVR fixtures and legacy_import.ts will
itself soon be deleted

* Update libs/utils tests

* Add a modifyCastVoteRecordExport fxn for modifying fixtures for tests

Also use more consistent variable names for raw file contents vs.
parsed contents

* Move helper for listing CVR exports out of legacy_cast_vote_records.ts

And then delete legacy_cast_vote_records.ts

* Remove old code paths from VxAdmin backend app.ts

* Update VxAdmin frontend to account for backend updates

* Update VxAdmin backend tests

* Set up getExportedCastVoteRecordIds helper

* Use constants for file names

* Use alternative import syntax to fix frontend builds

* Use build-stubs script to build fs stub in frontends missing that stub

* Distinguish no-entity from not-directory

apps/admin/backend/src/app.exports.test.ts

@@ -42,15 +42,15 @@ afterEach(() => {
 });
 
 test('batch export', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionGridLayoutNewHampshireAmherstFixtures;
 
   const { apiClient, auth, logger } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -86,15 +86,15 @@ test('batch export', async () => {
 });
 
 test('sems export', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
 
   const { apiClient, auth } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 

apps/admin/backend/src/app.results.test.ts

@@ -40,7 +40,7 @@ afterEach(() => {
 });
 
 test('card counts', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
   const { election } = electionDefinition;
 
@@ -49,7 +49,7 @@ test('card counts', async () => {
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -86,7 +86,7 @@ test('card counts', async () => {
 });
 
 test('election write-in adjudication summary', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionGridLayoutNewHampshireAmherstFixtures;
   const { election } = electionDefinition;
 
@@ -95,7 +95,7 @@ test('election write-in adjudication summary', async () => {
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 

apps/admin/backend/src/app.results_csv_export.test.ts

@@ -66,15 +66,15 @@ async function getParsedExport({
 }
 
 it('exports expected results for full election', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
 
   const { apiClient, auth, logger } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -132,15 +132,15 @@ it('exports expected results for full election', async () => {
 });
 
 it('logs failure if export fails for some reason', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
 
   const { apiClient, auth, logger } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -161,7 +161,7 @@ it('logs failure if export fails for some reason', async () => {
 });
 
 it('incorporates wia and manual data', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionGridLayoutNewHampshireAmherstFixtures;
   const { election } = electionDefinition;
 
@@ -170,7 +170,7 @@ it('incorporates wia and manual data', async () => {
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 

apps/admin/backend/src/app.tally_reports.test.ts

@@ -42,15 +42,15 @@ afterEach(() => {
 });
 
 test('general, full election, write in adjudication', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionGridLayoutNewHampshireAmherstFixtures;
 
   const { apiClient, auth } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -161,7 +161,7 @@ test('general, full election, write in adjudication', async () => {
 });
 
 test('general, reports by voting method, manual data', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionGridLayoutNewHampshireAmherstFixtures;
   const { election } = electionDefinition;
 
@@ -170,7 +170,7 @@ test('general, reports by voting method, manual data', async () => {
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -292,7 +292,7 @@ test('general, reports by voting method, manual data', async () => {
 });
 
 test('primary, full election', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
   const { election } = electionDefinition;
 
@@ -301,7 +301,7 @@ test('primary, full election', async () => {
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -355,7 +355,7 @@ test('primary, full election', async () => {
 });
 
 test('primary, full election, with manual results', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
   const { election } = electionDefinition;
 
@@ -364,7 +364,7 @@ test('primary, full election, with manual results', async () => {
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -410,15 +410,15 @@ test('primary, full election, with manual results', async () => {
 });
 
 test('primary, reports by ballot style', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
 
   const { apiClient, auth } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');
 
@@ -469,15 +469,15 @@ test('primary, reports by ballot style', async () => {
 });
 
 test('primary, reports grouped by voting method, filtered by precinct', async () => {
-  const { electionDefinition, castVoteRecordReport } =
+  const { electionDefinition, castVoteRecordExport } =
     electionTwoPartyPrimaryFixtures;
 
   const { apiClient, auth } = buildTestEnvironment();
   await configureMachine(apiClient, auth, electionDefinition);
   mockElectionManagerAuth(auth, electionDefinition.electionHash);
 
   const loadFileResult = await apiClient.addCastVoteRecordFile({
-    path: castVoteRecordReport.asDirectoryPath(),
+    path: castVoteRecordExport.asDirectoryPath(),
   });
   loadFileResult.assertOk('load file failed');