feat(scan): remove smartcard reports #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adghayes
force-pushed
the
drew/remove-smartcard-reports-from-scan
branch
from
f293edf
to
37de66a
Compare
adghayes
changed the title
adghayes
requested review from
jonahkagan,
kofi-q and
carolinemodic
and removed request for
a team and
jonahkagan
adghayes
commented
Jul 19, 2023
| REACT_APP_VX_PRECINCT_REPORT_DESTINATION=smartcard | ||
| REACT_APP_VX_PRECINCT_REPORT_DESTINATION=thermal-sheet-printer |
There was a problem hiding this comment.
We could just remove this now, but that would require differentiating on the frontend between thermal and non-thermal printers (or at least the ones we support). That's doable but it does require quite a bit of work, so easier just to punt until we settle on a single kind of printer.
adghayes
force-pushed
the
drew/remove-smartcard-reports-from-scan
branch
from
3cf138c
to
7f2a7c4
Compare
kofi-q
approved these changes
Jul 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes support for saving tally reports to smartcards in VxScan.
Checklist