Desktop theme Card #4140
Merged
Desktop theme Card #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove elevation effect - Remove margin - Add style prop
jonahkagan
requested review from
eventualbuddha
and removed request for
a team and
eventualbuddha
adghayes
reviewed
Oct 30, 2023
We don't really use elevation to group things anywhere else in our apps, so it felt inconsistent. This became especially apparent in the desktop theme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adapts the Card component for use in desktop apps. Currently it was only used in one place: the VxMark review screen, so it was a pretty easy change.
Then replaces the makeshift Card component in VxDesign with the libs/ui component.
Review by commit
Demo Video or Screenshot
Before
After
Testing Plan
Automated tests, visual confirmation
Checklist