change ballot package location on USB #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adghayes
force-pushed
the
drew/ballot-package-location
branch
3 times, most recently
from
44db019
to
dceb6ed
Compare
- changes directory structure that VxAdmin creates - removes a lot of unused file naming helpers from libs/utils
…ges follow correct structure
adghayes
force-pushed
the
drew/ballot-package-location
branch
from
dceb6ed
to
ec88964
Compare
adghayes
commented
Oct 31, 2023
| @@ -168,46 +161,6 @@ test("if there's only one precinct in the election, it's selected automatically | |||
| }); | |||
| }); | |||
|
|
|||
| test('configures using the most recently created ballot package on the usb drive', async () => { | |||
There was a problem hiding this comment.
this is tested in libs/backend and doesn't need to be tested here too
adghayes
requested review from
jonahkagan,
kshen0 and
arsalansufi
and removed request for
a team and
jonahkagan
|
@arsalansufi or @kshen0 tagging either of you for review as I've discussed this change with both of you on Slack. |
arsalansufi
approved these changes
Oct 31, 2023
| /** | ||
| * Generate the directory name for the cast vote record report. | ||
| * | ||
| * @deprecated |
There was a problem hiding this comment.
Thanks for removing these! Forgot about them when I was cleaning up old CVR code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3935. Previously, ballot packages would be exported to a USB drive like so:
./ballot-packages/sample-county_example-primary-election_06414087b1__2023-10-30_12-57-46.zipNow, we export them like this:
./sample-county_example-primary-election_06414087b1/ballot-packages/ballot-package__2023-10-30_12-56-55.zipThis means that all of our in-system files are being exported in the same way, to a top-level election directory, a file type subdirectory, then a filename. I kept
ballot-packagein the file name for the ballot package so that it wouldn't be just a date if it got out of context. Could add file hash in too if desirable.Testing Plan