-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change ballot package location on USB #4142
Conversation
44db019
to
dceb6ed
Compare
- changes directory structure that VxAdmin creates - removes a lot of unused file naming helpers from libs/utils
…ges follow correct structure
dceb6ed
to
ec88964
Compare
@@ -168,46 +161,6 @@ test("if there's only one precinct in the election, it's selected automatically | |||
}); | |||
}); | |||
|
|||
test('configures using the most recently created ballot package on the usb drive', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is tested in libs/backend
and doesn't need to be tested here too
@arsalansufi or @kshen0 tagging either of you for review as I've discussed this change with both of you on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/** | ||
* Generate the directory name for the cast vote record report. | ||
* | ||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing these! Forgot about them when I was cleaning up old CVR code
Overview
Closes #3935. Previously, ballot packages would be exported to a USB drive like so:
./ballot-packages/sample-county_example-primary-election_06414087b1__2023-10-30_12-57-46.zip
Now, we export them like this:
./sample-county_example-primary-election_06414087b1/ballot-packages/ballot-package__2023-10-30_12-56-55.zip
This means that all of our in-system files are being exported in the same way, to a top-level election directory, a file type subdirectory, then a filename. I kept
ballot-package
in the file name for the ballot package so that it wouldn't be just a date if it got out of context. Could add file hash in too if desirable.Testing Plan