[Node Upgrade] Revert packages using v8 coverage back to babel #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofi-q
commented
Sep 10, 2024
| @@ -35,6 +45,13 @@ beforeEach(() => { | |||
| featureFlagMock.enableFeatureFlag( | |||
| BooleanEnvironmentVariableName.SKIP_CAST_VOTE_RECORDS_AUTHENTICATION | |||
| ); | |||
| mockOf(initializeGetWorkspaceDiskSpaceSummary).mockReturnValue(() => | |||
There was a problem hiding this comment.
unrelated, but this test kept flaking locally, so copied this pattern from other tests that depend on this function to de-flake
carolinemodic
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prepping for a Node upgrade, 16 -> (hopefully) 20 and
v8coverage breaks in v20 (nodejs/node#51251). Moving back to thebabelcoverage provider in packages that we previously moved tov8Had to do some minor refactoring in a few cases to be able to mark the right blocks with
istanbul ignore, but no functional changes.