Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmarked write-in accounting tweaks #5408

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

adghayes
Copy link
Collaborator

Overview

Closes #5382. Does two things:

  • makes sure unmarked write-ins appear in the write-in adjudication report
  • undoes the WIA adjudication queue ordering that always puts UWIs last, which can be confusing if a UWI and a proper WI are on the same ballot contest

Testing Plan

Updated existing test coverage to match new logic.

@adghayes adghayes marked this pull request as ready for review September 16, 2024 16:08
@adghayes
Copy link
Collaborator Author

@arsalansufi re-assign review if needed, but wanted you tagged for review since this is a candidate for the potential v3.1.1 general patch, whether it's being tracked or not already.

* summary of write-in adjudication, they should be included because they
* exist in the adjudication flow just as marked write-ins do. The behavior
* can be controlled with the `includeUnadjudicatedAndInvalidUnmarkedWriteIns`
* flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "unadjudicated and unmarked write-ins" in this comment specifically read "unadjudicated and invalid unmarked write-ins"?

Even with that change, there's a bit of ambiguity as this could mean "unadjudicated marked write-ins and invalid unmarked write-ins". I think "unmarked write-ins that haven't been adjudicated or are invalid" might be clearer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, change incorporated.

I can see someone making the same complaint about the variable name, but I think it reads a bit clearer as a variable name, so I am inclined to leave it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had the same thought re variable name and agree that that's fine to leave as is

Copy link
Contributor

@arsalansufi arsalansufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adghayes adghayes merged commit d45fe51 into main Sep 16, 2024
62 checks passed
@adghayes adghayes deleted the drew/unmarked-wia-in-report branch September 16, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VxAdmin: UWIs in WIA Report
2 participants