Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mark-scan] HW diagnostic shows when PAT input is available and reachable #5439

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

kshen0
Copy link
Contributor

@kshen0 kshen0 commented Sep 26, 2024

Overview

#5275

Previously this page reported when a PAT device was plugged in, which is confusing in the context. Now it reports whether the PAT input is reachable by the daemon and backend, which is closer to the page's intent.

Demo Video or Screenshot

Screen.Recording.2024-09-25.at.5.45.42.PM.mov

Testing Plan

  • updated existing tests
  • added test for BMD 155 fallback
  • manually tested on VM

Checklist

  • I have added logging where appropriate to any new user actions, system updates such as file reads or storage writes, or errors introduced.
  • I have added a screenshot and/or video to this PR to demo the change
  • I have added the "user_facing_change" label to this PR to automate an announcement in #machine-product-updates

@kshen0 kshen0 marked this pull request as ready for review September 26, 2024 01:02
@kshen0 kshen0 requested a review from kofi-q September 26, 2024 01:04
@kshen0 kshen0 changed the title Kevin/mark scan diagnostic pat status [mark-scan] HW diagnostic shows when PAT input is available and reachable Sep 26, 2024
Copy link
Contributor

@kofi-q kofi-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kshen0 kshen0 merged commit 58e8360 into main Sep 26, 2024
62 checks passed
@kshen0 kshen0 deleted the kevin/mark-scan-diagnostic-pat-status branch September 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants