improved assertion error messages. added tests

vowsjs · Jun 13, 2010 · f10884d · f10884d
1 parent 72eecd7
commit f10884d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/lib/assert/macros.js b/lib/assert/macros.js
@@ -32,12 +32,12 @@ assert.matches = assert.match;
 
 assert.isTrue = function (actual, message) {
     if (actual !== true) {
-        assert.fail(actual, true, message || "expected {actual} to be {expected}", "===", assert.isTrue);
+        assert.fail(actual, true, message || "expected {expected}, got {actual}", "===", assert.isTrue);
     }
 };
 assert.isFalse = function (actual, message) {
     if (actual !== false) {
-        assert.fail(actual, false, message || "expected {actual} to be {expected}", "===", assert.isFalse);
+        assert.fail(actual, false, message || "expected {expected}, got {actual}", "===", assert.isFalse);
     }
 };
 assert.isZero = function (actual, message) {
@@ -47,7 +47,7 @@ assert.isZero = function (actual, message) {
 };
 assert.isNotZero = function (actual, message) {
     if (actual === 0) {
-        assert.fail(actual, 0, message || "expected {expected}, got {actual}", "===", assert.isNotZero);
+        assert.fail(actual, 0, message || "expected non-zero value, got {actual}", "===", assert.isNotZero);
     }
 };
 
@@ -117,12 +117,12 @@ assert.isNaN = function (actual, message) {
 };
 assert.isNull = function (actual, message) {
     if (actual !== null) {
-        assert.fail(actual, null, message || "expected {actual} to be {expected}", "===", assert.isNull);
+        assert.fail(actual, null, message || "expected {expected}, got {actual}", "===", assert.isNull);
     }
 };
 assert.isNotNull = function (actual, message) {
     if (actual === null) {
-        assert.fail(actual, null, message || "expected {actual} to not be {expected}", "===", assert.isNotNull);
+        assert.fail(actual, null, message || "expected non-null value, got {actual}", "===", assert.isNotNull);
     }
 };
 assert.isUndefined = function (actual, message) {

diff --git a/test/vows-test.js b/test/vows-test.js
@@ -44,6 +44,16 @@ vows.describe("Vows").addVows({
             assert.isNumber(0);
             assert.isNaN(0/0);
         },
+        "testing value": function (it) {
+            assert.isFalse(false);
+            assert.isTrue(true);
+            assert.isZero(0);
+            assert.isNotZero(1);
+            assert.isNull(null);
+            assert.isNotNull(0);
+            assert.greater(5, 4);
+            assert.lesser(4, 5);
+        },
         "testing emptiness": function (it) {
             assert.isEmpty({});
             assert.isEmpty([]);