Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when file arg uses absolute path #83

Closed
wants to merge 1 commit into from
Closed

Fix error when file arg uses absolute path #83

wants to merge 1 commit into from

Conversation

cliffano
Copy link

@cliffano cliffano commented May 7, 2011

'vows /absolute/path/to/testfile.js' results in an error because the current working directory is appended to the file arg.
Here's an example error message:
node.js:134
throw e; // process.nextTick error, or 'error' event on first tick
^
Error: Cannot find module '/absolute/path/current/working/directory/absolute/path/to/testfile'
at Function._resolveFilename (module.js:320:11)
at Function._load (module.js:266:25)
at require (module.js:348:19)
at /foobar/.npm/vows/0.5.8/package/bin/vows:369:19
at Array.reduce (native)
at importSuites (/foobar/.npm/vows/0.5.8/package/bin/vows:368:18)
at Object. (/foobar/.npm/vows/0.5.8/package/bin/vows:202:15)
at Module._compile (module.js:404:26)
at Object..js (module.js:410:10)
at Module.load (module.js:336:31)

Tested with node 0.4.5 on osx

@jmalloc
Copy link

jmalloc commented Jul 26, 2011

+1

indexzero added a commit that referenced this pull request Jul 27, 2011
@indexzero
Copy link

@cloudhead I've pushed this to a feature branch issue-83. Looks good to me. OK to merge this into master?

indexzero added a commit that referenced this pull request Aug 12, 2011
@indexzero
Copy link

This is published in vows@0.5.10

@indexzero indexzero closed this Aug 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants