Persist current slice during group modal navigation (#4836)

* fix fallback slice * group slice assertion when navigating samples * fix test
voxel51 · Sep 25, 2024 · 666f630 · 666f630
1 parent 3828d2e
commit 666f630
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/app/packages/state/src/hooks/useSetExpandedSample.ts b/app/packages/state/src/hooks/useSetExpandedSample.ts
@@ -27,9 +27,9 @@ export default () => {
             .filter(({ mediaType }) => !THREE_D.has(mediaType))
             .map(({ name }) => name)
             .sort()[0];
-        }
 
-        set(groupAtoms.modalGroupSlice, fallback);
+          set(groupAtoms.modalGroupSlice, fallback);
+        }
       },
     []
   );

diff --git a/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts b/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts
@@ -92,6 +92,13 @@ test.describe("quickstart-groups", () => {
       expect(await modal.sidebar.getSampleFilepath(false)).toEqual(
         FIRST_SAMPLE_FILENAME
       );
+
+      await modal.sidebar.toggleSidebarGroup("GROUP");
+      await modal.navigateSlice("group.name", "right");
+      await modal.navigateNextSample();
+      expect(await modal.sidebar.getSidebarEntryText("group.name")).toEqual(
+        "right"
+      );
     });
 
     test("group media visibility toggle works", async ({ modal }) => {