review changes 2

voxel51 · Oct 22, 2024 · 6f81d66 · 6f81d66
1 parent 3d67489
commit 6f81d66
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 35 deletions.
diff --git a/app/packages/components/src/components/MuiIconFont/index.tsx b/app/packages/components/src/components/MuiIconFont/index.tsx
@@ -2,36 +2,30 @@ import { Icon, IconProps } from "@mui/material";
 import "material-icons/iconfont/material-icons.css";
 import React from "react";
 
-// Available Icons: https://github.com/marella/material-icons?tab=readme-ov-file#available-icons
-export default function MuiIconFont(props: MuiIconFontProps) {
-  const { name, variant, ...iconProps } = props;
-
-  let icon = <Icon {...iconProps}>{name}</Icon>;
-
-  if (variant === "outlined") {
-    icon = (
-      <Icon {...iconProps} className="material-icons-outlined">
-        {name}
-      </Icon>
-    );
-  } else if (variant === "rounded") {
-    icon = (
-      <Icon {...iconProps} className="material-icons-rounded">
-        {name}
-      </Icon>
-    );
-  } else if (variant === "sharp") {
-    icon = (
-      <Icon {...iconProps} className="material-icons-sharp">
-        {name}
-      </Icon>
-    );
-  }
-
-  return icon;
-}
-
 type MuiIconFontProps = IconProps & {
   name: string;
   variant?: "filled" | "outlined" | "rounded" | "sharp";
 };
+
+const defaultProps = { variant: "filled" as const };
+
+// Available Icons: https://github.com/marella/material-icons?tab=readme-ov-file#available-icons
+const MuiIconFont = React.memo(function MuiIconFont(props: MuiIconFontProps) {
+  const { name, variant = defaultProps.variant, ...iconProps } = props;
+
+  const variantClassMap = {
+    filled: "",
+    outlined: "material-icons-outlined",
+    rounded: "material-icons-rounded",
+    sharp: "material-icons-sharp",
+  };
+
+  const className = variant ? variantClassMap[variant] : "";
+
+  return (
+    <Icon {...iconProps} className={className || undefined}>
+      {name}
+    </Icon>
+  );
+});
+export default MuiIconFont;
diff --git a/fiftyone/operators/types.py b/fiftyone/operators/types.py
@@ -2358,12 +2358,6 @@ class ModalView(Button):
     """
 
     def __init__(self, **kwargs):
-        if "primaryCallback" not in kwargs or not callable(
-            kwargs["primaryCallback"]
-        ):
-            raise ValueError(
-                "The 'primaryCallback' parameter is missing or must be function that is callable."
-            )
         super().__init__(**kwargs)