use default_group_slice

fiftyone/core/dataset.py

@@ -573,7 +573,10 @@ def group_slice(self, slice_name):
         if slice_name is None:
             slice_name = self._doc.default_group_slice
 
-        if slice_name not in self._doc.group_media_types:
+        if (
+            slice_name is not None
+            and slice_name not in self._doc.group_media_types
+        ):
             raise ValueError("Dataset has no group slice '%s'" % slice_name)
 
         self._group_slice = slice_name

fiftyone/operators/builtin.py

@@ -1518,7 +1518,11 @@ def execute(self, ctx):
         new_name = ctx.params["new_name"]
 
         ctx.dataset.rename_group_slice(name, new_name)
-        ctx.ops.set_group_slice(new_name)
+
+        # @todo ideally we would only set this if the group slice we renamed is
+        # currently loaded in the App
+        ctx.ops.set_group_slice(ctx.dataset.default_group_slice)
+
         ctx.ops.reload_dataset()
 
 
@@ -1565,16 +1569,11 @@ def execute(self, ctx):
         name = ctx.params["name"]
 
         ctx.dataset.delete_group_slice(name)
-        group_slices = ctx.dataset.group_slices
-        selected_group_slice = next(
-            (
-                group_slice
-                for group_slice in group_slices
-                if group_slice != name
-            ),
-            None,
-        )
-        ctx.ops.set_group_slice(selected_group_slice)
+
+        # @todo ideally we would only set this if the group slice we deleted is
+        # currently loaded in the App
+        ctx.ops.set_group_slice(ctx.dataset.default_group_slice)
+
         ctx.ops.reload_dataset()
 
 

fiftyone/operators/operations.py

@@ -630,10 +630,10 @@ def set_panel_title(self, id=None, title=None):
         )
 
     def set_group_slice(self, slice):
-        """Set the group slices in the App.
+        """Set the active group slice in the App.
 
         Args:
-            slice: the group slice to set
+            slice: the group slice to activate
         """
         return self._ctx.trigger("set_group_slice", {"slice": slice})