Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu 24.04 fiftyone-db support #4533

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add Ubuntu 24.04 fiftyone-db support #4533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc35c04
add Ubuntu 24.04 db support
benjaminpkane Jun 25, 2024
03518bc
rm redundant db source publish
benjaminpkane Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-db.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,10 @@ jobs:
python -Im build --sdist
- name: Upload
uses: actions/upload-artifact@v3
if: ${{ matrix.platform == 'sdist' }}
with:
name: dist-${{ matrix.platform }}
path: package/db/dist/*
path: package/db/dist/*.tar.gz
- name: Upload wheel
if: ${{ matrix.platform != 'sdist' }}
uses: actions/upload-artifact@v3
Expand Down
6 changes: 5 additions & 1 deletion package/db/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@
"aarch64": "https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2204-7.0.4.tgz",
"x86_64": "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2204-7.0.4.tgz",
},
"24": {
"aarch64": "https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2204-7.0.4.tgz",
"x86_64": "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2204-7.0.4.tgz",
},
Comment on lines +98 to +101
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The provided links are for Ubuntu 22.04, not 24.04.

The MongoDB download links in the setup.py file point to Ubuntu 22.04, as there are no references to Ubuntu 24.04 in the repository. This suggests that MongoDB does not yet officially support Ubuntu 24.04, and the links for Ubuntu 22.04 might have been used as placeholders.

  • package/db/setup.py: Lines 98-101
Analysis chain

Added Ubuntu 24.04 support with MongoDB download links.

The links provided are for Ubuntu 22.04, not 24.04. This might be due to MongoDB not yet supporting Ubuntu 24.04. Please confirm if these are the intended links or if it's a placeholder until official support is released.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check MongoDB official support for Ubuntu 24.04.

# Test: Search for official MongoDB release for Ubuntu 24.04. Expect: Confirmation of the release or lack thereof.
rg --type markdown $'Ubuntu 24.04' README.md

Length of output: 45

Script:

#!/bin/bash
# Search for any references to Ubuntu 24.04 in the repository to gather more information.
rg 'Ubuntu 24.04'

# Verify the MongoDB download links in the setup.py file to ensure they are correct.
rg 'mongodb-linux' package/db/setup.py

Length of output: 2933

},
}

Expand Down Expand Up @@ -139,7 +143,7 @@ def _get_download():
MONGODB_BINARIES = ["mongod"]


VERSION = "1.1.3"
VERSION = "1.1.4"


def get_version():
Expand Down
Loading