Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ultralytics #4721

Closed
wants to merge 1 commit into from
Closed

Fix ultralytics #4721

wants to merge 1 commit into from

Conversation

kaixi-wang
Copy link
Contributor

@kaixi-wang kaixi-wang commented Aug 23, 2024

What changes are proposed in this pull request?

fixes array len

How is this patch tested? If it is not, please explain why.

import fiftyone as fo
import fiftyone.zoo as foz
import fiftyone.utils.huggingface as fouh
from fiftyone import ViewField as F

dataset = fouh.load_from_hub(
    "Voxel51/VisDrone2019-DET",
    name="sahi-test",
    max_samples=25,
    overwrite=True
    )
dataset = fouh.load_from_hub(
    "Voxel51/VisDrone2019-DET",
    name="sahi-test",
    max_samples=25,
    overwrite=True
    )
model = foz.load_zoo_model(
    "yolov8l-coco-torch",
    device="cuda"
    )

dataset.apply_model(model, label_field="predictions")

above snippet no longer throws error

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • Bug Fixes
    • Improved the clarity and performance of the track ID extraction process for non-tracked results.

@kaixi-wang kaixi-wang self-assigned this Aug 23, 2024
Copy link
Contributor

coderabbitai bot commented Aug 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes made in the fiftyone/utils/ultralytics.py file involve a simplification in the _extract_track_ids function. The approach for generating a list of None values when result.boxes.is_track is false has been streamlined by removing an unnecessary len() function call, enhancing the clarity of the code while retaining the original logic and functionality.

Changes

File Change Summary
fiftyone/utils/ultralytics.py Simplified the generation of a list of None values in _extract_track_ids by directly using result.boxes.conf.size(0) instead of len().

Poem

In the code where rabbits hop,
A simplification made the clutter stop.
No need for lengths, just a direct call,
Improving clarity, that's the goal for all!
With each small change, we leap with glee,
In the world of code, we're forever free! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@swheaton
Copy link
Contributor

dupe #4720

@swheaton swheaton closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants