-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MedSAM2 to the model zoo #4828
Conversation
I will rebase develop before merging :) |
WalkthroughThe changes enhance the Changes
Poem
Recent review detailsConfiguration used: .coderabbit.yaml Files ignored due to path filters (1)
Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@@ -145,6 +163,17 @@ | |||
prompt_field="frames.detections", # can contain Detections or Keypoints | |||
) | |||
|
|||
session = fo.launch_app(dataset) | |||
{% elif 'med-sam' in name %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: move this elif
block above line 156 so that you can remove and 'med-SAM' not in tags
from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a static review standpoint, just left one suggestion.
Defer to @danielgural for a functional review (I didn't try running the model)
cb4a884
to
8c1e86f
Compare
What changes are proposed in this pull request?
Adding MedSAM2 to the model ZOO by adding documentation to this PR by Evatt Harvey Salinger.
How is this patch tested? If it is not, please explain why.
Manually tested
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
This PR adds MedSAM2 to the FiftyOne Model Zoo. Detailed description in this PR.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit