Remove deprecated fiftyone-desktop refs

[brimoor]

Resolves #4880
Resolves #4889

Tested by

fiftyone quickstart

Summary by CodeRabbit

• New Features
  • Simplified the quickstart process by removing the desktop application option from the interface.
• Bug Fixes
  • Eliminated fallback logic for the FIFTYONE_DESKTOP_APP_DIR, streamlining the app setup process.
• Improvements
  • Enhanced session management by standardizing the waiting behavior across different session types.

[coderabbitai]

Walkthrough

The changes in this pull request involve the removal of the FIFTYONE_DESKTOP_APP_DIR constant from fiftyone/constants.py, which eliminates the associated fallback logic for its import. Additionally, the quickstart function and related helper functions in fiftyone/utils/quickstart.py have been modified to remove the desktop parameter from their signatures and associated calls, reflecting a simplification of the interface. Modifications to the Session class in fiftyone/core/session/session.py streamline the waiting behavior for sessions.

Changes

File	Change Summary
fiftyone/constants.py	Removed FIFTYONE_DESKTOP_APP_DIR constant and its fallback import logic.
fiftyone/utils/quickstart.py	Removed desktop parameter from quickstart, _quickstart, _video_quickstart, and _launch_app functions; updated function calls accordingly.
fiftyone/core/session/session.py	Modified wait method in Session class to simplify waiting behavior and removed remote handling.

Assessment against linked issues

Objective	Addressed	Explanation
Remove desktop parameter to fix launch issue (4880)	✅

Possibly related PRs

• Remove deprecated methods for 1.0 #4832: The removal of deprecated methods in fiftyone/core/dataset.py indicates a similar approach to cleaning up the codebase.

Suggested labels

cleaning

🐇 In the code, a change so bright,
The desktop's gone, now feels just right.
Quickstart's path is clear and neat,
No more clutter, just a swift feat!
Hopping along, we celebrate,
With cleaner code, we elevate! 🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b375477 and 2496795.

📒 Files selected for processing (1)

• fiftyone/core/session/session.py (1 hunks)

🔇 Additional comments (2)

fiftyone/core/session/session.py (2)

Line range hint 1128-1139: Improved wait mechanism for better flexibility

The changes to the wait method are well-implemented and offer several improvements:

1. Consistent behavior across all session types by removing the self.remote check.
2. More flexible control over the waiting process through the use of self._wait_closed attribute.
3. Retained the ability to specify a custom wait duration.
4. Proper handling of KeyboardInterrupt for a better user experience.

These changes should result in a more robust and flexible waiting mechanism for the session.

---

Line range hint 1-1139: Overall assessment: Improved session management

The changes in this file, particularly in the wait method of the Session class, contribute positively to the project's goals. By simplifying the waiting mechanism and making it more consistent across different session types, the code becomes more maintainable and robust. These improvements align well with the PR objectives of removing deprecated references and enhancing functionality.

No issues or concerns were identified in the changes, and the modifications appear to be well-thought-out and implemented.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brimoor]

@benjaminpkane when I run fiftyone quickstart on this branch, the App now launches but it appears to immediately exit. Can you reproduce? Is session.wait() also broken?

[benjaminpkane]

@benjaminpkane when I run fiftyone quickstart on this branch, the App now launches but it appears to immediately exit. Can you reproduce? Is session.wait() also broken?

Fixed. My mistake