-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID_LIKE fallback for fiftyone-db #4903
Conversation
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
package/db/setup.py (1)
151-154
: Approve changes with a suggestion for improved error handlingThe addition of the
ID_LIKE
fallback mechanism is a good improvement that addresses the PR objective of enhancing support for various Linux distributions. This change will allow the script to handle distributions based on major distributions more effectively.Consider adding error handling for cases where both
ID
andID_LIKE
are not found inLINUX_DOWNLOADS
. This could prevent potential KeyErrors and provide more informative feedback. Here's a suggested implementation:key = d["ID"].lower() if key not in LINUX_DOWNLOADS: key = d["ID_LIKE"].lower() + if key not in LINUX_DOWNLOADS: + raise ValueError(f"Unsupported Linux distribution: ID={d['ID']}, ID_LIKE={d['ID_LIKE']}")
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- package/db/setup.py (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
package/db/setup.py (2)
178-178
: Version update approvedThe increment of the
VERSION
variable from "1.1.6" to "1.1.7" is appropriate for the changes made in this PR. It follows semantic versioning principles by incrementing the patch version for a backwards-compatible enhancement.
Line range hint
1-324
: Summary of changesThis PR successfully implements the fallback mechanism for Linux distributions using the
ID_LIKE
field from/etc/os-release
. The changes align well with the PR objectives and improve the package's functionality for a wider range of Linux distributions.The version update to 1.1.7 is appropriate for the nature of these changes.
Overall, the implementation looks solid, with only a minor suggestion for improved error handling. Great work on enhancing the compatibility of the
fiftyone-db
package!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems legit
What changes are proposed in this pull request?
To support more Linux varieties, e.g.
Aurora
based onFedora
, fall back to theID_LIKE
entry in/etc/os-release
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit