ID_LIKE fallback for fiftyone-db

[benjaminpkane]

What changes are proposed in this pull request?

To support more Linux varieties, e.g. Aurora based on Fedora, fall back to the ID_LIKE entry in /etc/os-release

NAME="Aurora"
VERSION="40.20240930.0 (Kinoite)"
ID=aurora
ID_LIKE="fedora"
VERSION_ID=40
VERSION_CODENAME="Archaeopteryx"
PLATFORM_ID="platform:f40"

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• New Features
  • Improved support for various Linux distributions during package installation.
• Version Update
  • Updated package version from 1.1.6 to 1.1.7.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve updates to the setup.py file for the fiftyone-db package. Notably, support for various Linux distributions has been added in the _get_linux_download function, which now utilizes the ID_LIKE field from the /etc/os-release file for better download URL retrieval. Additionally, the package version has been incremented from 1.1.6 to 1.1.7, reflecting this change in the VERSION variable used for version validation.

Changes

File	Change Summary
package/db/setup.py	- Updated VERSION from 1.1.6 to 1.1.7. - Enhanced _get_linux_download to check ID_LIKE in /etc/os-release for better distribution support.

Possibly related PRs

• Add Ubuntu 24.04 fiftyone-db support #4533: This PR updates the VERSION variable in setup.py from 1.1.3 to 1.1.4, which is related to the version update in the main PR from 1.1.6 to 1.1.7.
• Add Fedora support to fiftyone-db #4866: This PR also updates the VERSION variable in setup.py from 1.1.5 to 1.1.6, showing a similar pattern of version updates in the setup.py file.

Suggested reviewers

• findtopher

🐇 In the meadow, hopping free,
A version change, oh joy for me!
Linux distributions now align,
With downloads smooth, all will be fine.
From 1.1.6 to 1.1.7, we cheer,
A brighter path for all, my dear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

package/db/setup.py (1)

151-154: Approve changes with a suggestion for improved error handling

The addition of the ID_LIKE fallback mechanism is a good improvement that addresses the PR objective of enhancing support for various Linux distributions. This change will allow the script to handle distributions based on major distributions more effectively.

Consider adding error handling for cases where both ID and ID_LIKE are not found in LINUX_DOWNLOADS. This could prevent potential KeyErrors and provide more informative feedback. Here's a suggested implementation:

 key = d["ID"].lower()
 if key not in LINUX_DOWNLOADS:
     key = d["ID_LIKE"].lower()
+    if key not in LINUX_DOWNLOADS:
+        raise ValueError(f"Unsupported Linux distribution: ID={d['ID']}, ID_LIKE={d['ID_LIKE']}")

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 739d6b1 and da2e216.

📒 Files selected for processing (1)

• package/db/setup.py (2 hunks)

🧰 Additional context used

🔇 Additional comments (2)

package/db/setup.py (2)

178-178: Version update approved

The increment of the VERSION variable from "1.1.6" to "1.1.7" is appropriate for the changes made in this PR. It follows semantic versioning principles by incrementing the patch version for a backwards-compatible enhancement.

---

Line range hint 1-324: Summary of changes

This PR successfully implements the fallback mechanism for Linux distributions using the ID_LIKE field from /etc/os-release. The changes align well with the PR objectives and improve the package's functionality for a wider range of Linux distributions.

The version update to 1.1.7 is appropriate for the nature of these changes.

Overall, the implementation looks solid, with only a minor suggestion for improved error handling. Great work on enhancing the compatibility of the fiftyone-db package!

[findtopher]

seems legit